fix(prevent): Improve redirects to pages that exist wrt the Prevent main nav button#106489
Merged
fix(prevent): Improve redirects to pages that exist wrt the Prevent main nav button#106489
Conversation
github-actions
bot
added
the
Scope: Frontend
shashjar
approved these changes
Jan 20, 2026
| </SidebarLink> | ||
| ) : ( | ||
| <SidebarLink | ||
| to={`/${prefix}/${PREVENT_BASE_URL}/${PREVENT_AI_BASE_URL}/new/`} |
Member
There was a problem hiding this comment.
are we able to use makePreventPathname here as well?
Member
Author
There was a problem hiding this comment.
i'm thinking i'm going to skip makePreventPathname in both places. None of the other links use a make* function like that, so they're not having normalizeUrl() called on the url either.
The Prevent grouping is going away, so i don't want to be making a new pattern inside it. We could/should make urls easier to deal with, but we can followup and do that across a wider swath of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #105346
In that previous PR i added a redirect to the AI config page, which would kick you out of the Prevent area making the Test Analytics pages inaccessible. This changes the url within the main nav to point to whichever sub-nav items are available. You'll get either:
also fixed the
navigate()call to be a proper redirect, replacing the url instead of appending to history.