Skip to content

feat(preprod): Reland quota check#106523

Merged
chromy merged 3 commits intomasterfrom
chromy/2026-01-19-reland-behind-flag
Jan 20, 2026
Merged

feat(preprod): Reland quota check#106523
chromy merged 3 commits intomasterfrom
chromy/2026-01-19-reland-behind-flag

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Jan 19, 2026

@chromy chromy requested a review from a team as a code owner January 19, 2026 16:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 19, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


return preprod_artifact

except NoPreprodQuota:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size metrics created without checking SIZE_ANALYSIS quota

Medium Severity

The diff removes the TODO comment # TODO(preprod): add gating to only create if has quota but doesn't implement the gating. PreprodArtifactSizeMetrics is created unconditionally in PENDING state, even when the organization only has INSTALLABLE_BUILD quota and not SIZE_ANALYSIS quota. Since size analysis won't run without quota, these records will remain stuck in PENDING state forever. The org_has_size_quota variable is already computed (line 210) but isn't used to gate the size metrics creation.

Fix in Cursor Fix in Web

@chromy chromy merged commit db9ab79 into master Jan 20, 2026
66 checks passed
@chromy chromy deleted the chromy/2026-01-19-reland-behind-flag branch January 20, 2026 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants