Skip to content

feat(dashboards): register backend overview#106541

Merged
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/browse-246-register-backend-overview-on-backend
Jan 19, 2026
Merged

feat(dashboards): register backend overview#106541
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/browse-246-register-backend-overview-on-backend

Conversation

@DominikB2014
Copy link
Contributor

Register backend overview as prebuilt dashboard

@DominikB2014 DominikB2014 requested a review from a team as a code owner January 19, 2026 21:26
@linear
Copy link

linear bot commented Jan 19, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 19, 2026
Comment on lines +138 to +141
{
"prebuilt_id": PrebuiltDashboardId.BACKEND_OVERVIEW,
"title": "Backend Overview",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new 'Backend Overview' dashboard is registered but won't be synced because its ID (12) isn't added to the dashboards.prebuilt-dashboard-ids option, which is empty by default.
Severity: HIGH

Suggested Fix

To enable the new 'Backend Overview' dashboard, add its ID (12) to the default list for the dashboards.prebuilt-dashboard-ids option in src/sentry/options/defaults.py. This will ensure it is synced for organizations by default.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/dashboards/endpoints/organization_dashboards.py#L138-L141

Potential issue: The PR adds the 'Backend Overview' prebuilt dashboard with ID `12`.
However, the dashboard synchronization logic in `sync_prebuilt_dashboards()` only
creates dashboards whose IDs are present in the `dashboards.prebuilt-dashboard-ids`
system option or if the
`organizations:dashboards-sync-all-registered-prebuilt-dashboards` feature flag is
active. Since the option defaults to an empty list and the flag is not enabled by this
PR, the new dashboard will never be created for any organization. This makes the new
feature non-functional by default.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, we don't want it enabled

@DominikB2014 DominikB2014 enabled auto-merge (squash) January 19, 2026 21:33
@DominikB2014 DominikB2014 merged commit d53c4ba into master Jan 19, 2026
67 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-246-register-backend-overview-on-backend branch January 19, 2026 21:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants