feat(attribute-breakdown): Open in expanded modal#106559
feat(attribute-breakdown): Open in expanded modal#106559nsdeschenes merged 16 commits intomasterfrom
Conversation
|
@sentry review |
|
@cursor review |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
force-pushed
the
nd/exp-714/feat-attribute-breakdown-open-in-modal
branch
from
0125def to
76d3c2e
Compare
|
@sentry review |
|
@cursor review |
static/app/views/explore/components/attributeBreakdowns/attributeBreakdownViewerModal.tsx
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
force-pushed
the
nd/exp-714/feat-attribute-breakdown-open-in-modal
branch
from
57aebcb to
0b6af0e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const singleTableData = distributionToTableData( | ||
| attributeDistribution.values, | ||
| cohortCount | ||
| ); |
There was a problem hiding this comment.
Chart and table show inconsistent data in modal
Medium Severity
The modal chart and table display different data when attributes have more than 40 unique values. distributionToSeriesData and cohortsToSeriesData apply .slice(0, CHART_MAX_SERIES_LENGTH) to limit chart data to 40 items, but distributionToTableData and cohortsToTableData do not apply this limit. This causes the chart to show only the top 40 items while the table shows all items, which is confusing for users trying to inspect their data.
Additional Locations (1)
static/app/views/explore/components/attributeBreakdowns/attributeBreakdownViewerModal.tsx
Show resolved
Hide resolved
nsdeschenes
deleted the
nd/exp-714/feat-attribute-breakdown-open-in-modal
branch
2 participants
This PR adds the functionality for users to be able to expand their attribute breakdown charts (single, and comparison mode) into a modal with the chart and table data so they can inspect the data more closely.
Ticket: EXP-714
Screenshots:
Single mode:
Comparison mode:
