chore(aci): default tests to workflow engine#106589
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
ceorourke
approved these changes
Jan 20, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
Mostly LGTM, just one question about a deleted test
| "sentry.notifications.notification_action.registry.issue_alert_handler_registry.get", | ||
| return_value=PagerDutyIssueAlertHandler, | ||
| ) | ||
| def test_name_action_with_custom_name( |
Member
There was a problem hiding this comment.
Do we not have custom names in workflow engine?
Contributor
Author
There was a problem hiding this comment.
The error detector is always named Error Monitor... we can change this though
trevor-e
pushed a commit
that referenced
this pull request
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the PR to default the actual logic to workflow engine much easier 😅