-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(preprod): Delete deprecated columns #106592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4ee6d6b to
60fbb6b
Compare
cd6fb6d to
2ebc324
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Moved preprodartifact.build_version field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.build_number field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_name field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_icon_id field to pending deletion state
--
-- (no-op)for --
-- Remove field build_version from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_version" CASCADE;
--
-- Remove field build_number from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_number" CASCADE;
--
-- Remove field app_name from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_name" CASCADE;
--
-- Remove field app_icon_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_icon_id" CASCADE; |
60fbb6b to
c70438e
Compare
2ebc324 to
d07081e
Compare
d07081e to
564b46c
Compare
c70438e to
c4c7cbe
Compare
564b46c to
c4c0dd8
Compare
c4c7cbe to
a556be0
Compare
c4c0dd8 to
449e32c
Compare
src/sentry/preprod/migrations/0024_delete_deprecated_preprod_artifact_fields.py
Show resolved
Hide resolved
449e32c to
062b5b3
Compare
062b5b3 to
e1a26c4
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Moved preprodartifact.build_version field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.build_number field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_name field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_icon_id field to pending deletion state
--
-- (no-op) |
Following https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns, this now properly marks the deprecated columns as ready for deletion, which sets us up to delete in #106592
e1a26c4 to
0b4d9ab
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Remove field build_version from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_version" CASCADE;
--
-- Remove field build_number from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_number" CASCADE;
--
-- Remove field app_name from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_name" CASCADE;
--
-- Remove field app_icon_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_icon_id" CASCADE; |

Following https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns, this fully deletes deprecated columns from PreprodArtifact.