Skip to content

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Jan 20, 2026

Following https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns, this fully deletes deprecated columns from PreprodArtifact.

@rbro112 rbro112 requested a review from a team as a code owner January 20, 2026 19:06
Copy link
Member Author

rbro112 commented Jan 20, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 20, 2026
@rbro112 rbro112 force-pushed the ryan/mark_deprecated_columns_as_ready_for_deletion branch from 4ee6d6b to 60fbb6b Compare January 20, 2026 19:08
@rbro112 rbro112 force-pushed the ryan/delete_deprecated_columns branch from cd6fb6d to 2ebc324 Compare January 20, 2026 19:08
@rbro112 rbro112 changed the title Delete deprecated columns chore(preprod): Delete deprecated columns Jan 20, 2026
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0023_remove_deprecated_preprod_artifact_fields.py src/sentry/preprod/migrations/0024_delete_deprecated_preprod_artifact_fields.py

for 0023_remove_deprecated_preprod_artifact_fields in preprod

--
-- Moved preprodartifact.build_version field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.build_number field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_name field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_icon_id field to pending deletion state
--
-- (no-op)

for 0024_delete_deprecated_preprod_artifact_fields in preprod

--
-- Remove field build_version from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_version" CASCADE;
--
-- Remove field build_number from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_number" CASCADE;
--
-- Remove field app_name from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_name" CASCADE;
--
-- Remove field app_icon_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_icon_id" CASCADE;

@rbro112 rbro112 force-pushed the ryan/mark_deprecated_columns_as_ready_for_deletion branch from 60fbb6b to c70438e Compare January 20, 2026 19:48
@rbro112 rbro112 force-pushed the ryan/delete_deprecated_columns branch from 2ebc324 to d07081e Compare January 20, 2026 19:48
@rbro112 rbro112 force-pushed the ryan/delete_deprecated_columns branch from d07081e to 564b46c Compare January 20, 2026 20:49
@rbro112 rbro112 force-pushed the ryan/mark_deprecated_columns_as_ready_for_deletion branch from c70438e to c4c7cbe Compare January 20, 2026 20:49
@rbro112 rbro112 force-pushed the ryan/delete_deprecated_columns branch from 564b46c to c4c0dd8 Compare January 20, 2026 23:35
@rbro112 rbro112 force-pushed the ryan/mark_deprecated_columns_as_ready_for_deletion branch from c4c7cbe to a556be0 Compare January 20, 2026 23:35
@rbro112 rbro112 force-pushed the ryan/delete_deprecated_columns branch from c4c0dd8 to 449e32c Compare January 20, 2026 23:57
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0023_remove_deprecated_preprod_artifact_fields.py

for 0023_remove_deprecated_preprod_artifact_fields in preprod

--
-- Moved preprodartifact.build_version field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.build_number field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_name field to pending deletion state
--
-- (no-op)
--
-- Moved preprodartifact.app_icon_id field to pending deletion state
--
-- (no-op)

rbro112 added a commit that referenced this pull request Jan 21, 2026
Following
https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns,
this now properly marks the deprecated columns as ready for deletion,
which sets us up to delete in #106592
Base automatically changed from ryan/mark_deprecated_columns_as_ready_for_deletion to master January 21, 2026 18:17
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0024_delete_deprecated_preprod_artifact_fields.py

for 0024_delete_deprecated_preprod_artifact_fields in preprod

--
-- Remove field build_version from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_version" CASCADE;
--
-- Remove field build_number from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "build_number" CASCADE;
--
-- Remove field app_name from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_name" CASCADE;
--
-- Remove field app_icon_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "app_icon_id" CASCADE;

@rbro112 rbro112 merged commit 52fa578 into master Jan 21, 2026
92 checks passed
@rbro112 rbro112 deleted the ryan/delete_deprecated_columns branch January 21, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants