Conversation
github-actions
bot
added
the
Scope: Backend
leeandher
changed the base branch from
master
to
leander/sai-region-service-7.5-toctou-fix
leeandher
force-pushed
the
leander/sai-region-service-9-implement-installation_service_hook_projects
branch
from
58919aa to
3ee01bc
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
markstory
approved these changes
Jan 22, 2026
src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py
Show resolved
Hide resolved
Base automatically changed from
leander/sai-region-service-7.5-toctou-fix
to
master
January 22, 2026 17:53
…dpoint" This reverts commit f766566.
- Use RPC calls instead of direct DB access for cross-silo compatibility - Pass existing_project_ids to prevent TOCTOU race conditions - Use extra_projects_to_fetch to validate project access - Remove pagination wrapper, return Response directly - Add endpoint to pagination allowlist
Add _get_auth_context helper to construct AuthenticationContext from request and pass it to get/set/delete service hook project RPC calls. Co-Authored-By: Claude <noreply@anthropic.com>
leeandher
force-pushed
the
leander/sai-region-service-9-implement-installation_service_hook_projects
branch
from
3ee01bc to
b44b155
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py
Show resolved
Hide resolved
markstory
approved these changes
Jan 22, 2026
leeandher
deleted the
leander/sai-region-service-9-implement-installation_service_hook_projects
branch
leeandher
added a commit
that referenced
this pull request
Jan 23, 2026
moves ~~several~~ all sentry app installation endpoints from `all_silo_endpoint` to `control_silo_endpoint`. updated test decorators and whatnot too now that the deploy has rolled through, this is a safe migration to make em cell-safe, ~~the only one not moved is the service hooks endpoint which will need #106621 to be merged and rolled through~~ moves all 6 endpoints now, no caveats requires #106621 to be deployed through
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
moves ~~several~~ all sentry app installation endpoints from `all_silo_endpoint` to `control_silo_endpoint`. updated test decorators and whatnot too now that the deploy has rolled through, this is a safe migration to make em cell-safe, ~~the only one not moved is the service hooks endpoint which will need #106621 to be merged and rolled through~~ moves all 6 endpoints now, no caveats requires #106621 to be deployed through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert service hook projects endpoint from region-only to all-silo by moving access validation to the region RPC service.
Pass AuthenticationContext from endpoint to RPC methods for proper permission checks.
Requires #106526 to deploy