feat(code_review): Improve debuggability by armenzg · Pull Request #106880 · getsentry/sentry

armenzg · 2026-01-23T16:53:15Z

This is a follow-up to #106567 and fixes the issue we found when it was deployed (SENTRY-5H53). For this line: extra = extract_github_info(event, github_event=github_event.value) we had an AttributeError: 'str' object has no attribute 'value'.

Description

This PR adds the extract_github_info() function to extract GitHub metadata from webhook events for improved debugging and logging.

In the future, we should also add this ability to Seer's code review code path.

Changes

New Function: `extract_github_info()`

Extracts GitHub metadata from webhook event payloads
Returns a dictionary with:
- github_owner: Repository owner/organization name
- github_repo_name: Repository name
- github_repo_full_name: Full repository name (owner/repo)
- github_event_url: URL to the specific event (check_run, pull_request, or comment)

Integration

Updated handle_webhook_event() in handlers.py to use extract_github_info()
Extracted metadata is passed as extra parameter to event handlers
Updated check_run.py, issue_comment.py, and pull_request.py to accept extra parameter

Testing

Added comprehensive unit test suite with 14 test cases
Tests cover all event types (pull_request, check_run, issue_comment)
Tests verify URL precedence logic (comment > check_run > pull_request)
Tests use real GitHub webhook fixtures for better accuracy
Edge cases tested (missing data, empty events, etc.)

Fixtures

Updated GitHub fixtures to include complete repository metadata
Added missing repository.name and repository.owner.login fields

Fixes CW-299

This reverts commit f168ef2.

linear · 2026-01-23T16:53:20Z

CW-299 Make logging for debugging code review

src/sentry/seer/code_review/webhooks/check_run.py

armenzg · 2026-01-26T20:13:48Z

fixtures/github.py

We're adding some extra metadata which already exists in GitHub events but were never added to the fixtures.

armenzg · 2026-01-26T20:15:39Z

src/sentry/integrations/github/webhook.py

The big improvement on this PR versus the previous one is that we add this module to the stronger typing list, thus, issues like SENTRY-5H53 should not happen.

armenzg · 2026-01-26T20:23:40Z

src/sentry/seer/code_review/webhooks/handlers.py

        **kwargs: Additional keyword arguments
    """
+    # The extracted important key values are used for debugging with logs
+    extra = extract_github_info(event, github_event=github_event.value)


We extract the key values as early as possible in the entry point handler and pass the values to all downstream logging.

Hey I'm pretty sure this is going to error again unless we move this down to line 56 after the GITHUB_ENTERPRISE check.

This is the same thing I encountered here with the sentry issue here.

The problem is that the type of github_event is wrong and is str in the case of the github enterprise class not enum. Maybe it's better if we fix the type in the github enterprise check here . Yeah either that or move these lines extracting extra to under the ghe check

armenzg · 2026-01-26T20:23:58Z

src/sentry/seer/code_review/webhooks/handlers.py

        repo=repo,
        integration=integration,
        org_code_review_settings=preflight.settings,
+        extra=extra,


Passing it to the downstream handlers.

armenzg · 2026-01-26T20:28:40Z

src/sentry/seer/code_review/webhooks/task.py

    *,
    enqueued_at_str: str,
-    github_event: GithubWebhookType,
+    github_event: str,


When the task gets scheduled, Celery JSON serializes the data and we lose the Enum type.

I'm investigating if there's any tool we could add to prevent issues like this.

Oh good to know, I can definitely see myself falling into that trap again

armenzg · 2026-01-26T20:35:33Z

@sentry review

srest2021 · 2026-01-26T23:28:37Z

src/sentry/seer/code_review/webhooks/issue_comment.py

            organization_id=organization.id,
            repo=repo,
            pr_number=str(pr_number) if pr_number else None,
            comment_id=str(comment_id),


It would be ideal if we could pass extra in here and also the callsite in pull_request.py and log a warning every time we do record_webhook_handler_error. Happy to address this in a followup PR after this gets merged 👍

Hi @srest2021 I will let you handle since I'm unsure what you have in mind.

suejung-sentry

this makes sense but just a warning to address this or I'm pretty sure it's gonna error again

suejung-sentry · 2026-01-26T23:26:28Z

src/sentry/seer/code_review/webhooks/task.py

    *,
    enqueued_at_str: str,
-    github_event: GithubWebhookType,
+    github_event: str,


Oh good to know, I can definitely see myself falling into that trap again

suejung-sentry · 2026-01-26T23:32:19Z

src/sentry/seer/code_review/webhooks/handlers.py

        **kwargs: Additional keyword arguments
    """
+    # The extracted important key values are used for debugging with logs
+    extra = extract_github_info(event, github_event=github_event.value)


Hey I'm pretty sure this is going to error again unless we move this down to line 56 after the GITHUB_ENTERPRISE check.

This is the same thing I encountered here with the sentry issue here.

The problem is that the type of github_event is wrong and is str in the case of the github enterprise class not enum. Maybe it's better if we fix the type in the github enterprise check here . Yeah either that or move these lines extracting extra to under the ghe check

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-27T13:12:33Z

src/sentry/seer/code_review/webhooks/handlers.py

        return

+    # The extracted important key values are used for debugging with logs
+    extra = extract_github_info(event, github_event=github_event.value)


Calling .value on string fails for GitHub Enterprise

High Severity

The call to github_event.value at this line assumes github_event is always a GithubWebhookType enum, but GitHub Enterprise webhook handlers pass github_event as a raw string (from request.headers.get("x-github-event")). While there's a GitHub Enterprise check at lines 51-52 that should return early, a reviewer explicitly raised concerns that this will still error. The original bug this PR fixes was exactly AttributeError: 'str' object has no attribute 'value' on this line.

This is a follow-up to #106567 and fixes the issue we found when it was deployed ([SENTRY-5H53](https://sentry.sentry.io/issues/7210274284/)). For this line: `extra = extract_github_info(event, github_event=github_event.value)` we had an `AttributeError: 'str' object has no attribute 'value'`. ## Description This PR adds the `extract_github_info()` function to extract GitHub metadata from webhook events for improved debugging and logging. In the future, we should also add this ability to Seer's code review code path. ## Changes ### New Function: `extract_github_info()` - Extracts GitHub metadata from webhook event payloads - Returns a dictionary with: - `github_owner`: Repository owner/organization name - `github_repo_name`: Repository name - `github_repo_full_name`: Full repository name (owner/repo) - `github_event_url`: URL to the specific event (check_run, pull_request, or comment) ### Integration - Updated `handle_webhook_event()` in `handlers.py` to use `extract_github_info()` - Extracted metadata is passed as `extra` parameter to event handlers - Updated `check_run.py`, `issue_comment.py`, and `pull_request.py` to accept `extra` parameter ### Testing - Added comprehensive unit test suite with 14 test cases - Tests cover all event types (pull_request, check_run, issue_comment) - Tests verify URL precedence logic (comment > check_run > pull_request) - Tests use real GitHub webhook fixtures for better accuracy - Edge cases tested (missing data, empty events, etc.) ### Fixtures - Updated GitHub fixtures to include complete repository metadata - Added missing `repository.name` and `repository.owner.login` fields Fixes [CW-299](https://linear.app/getsentry/issue/CW-299)

armenzg added 2 commits January 22, 2026 09:51

Reapply "feat(code_review): Improve debuggability (#106567)"

f458f89

This reverts commit f168ef2.

Strongly type webhook

4e77afa

armenzg self-assigned this Jan 23, 2026

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 23, 2026

vercel bot deployed to Preview January 23, 2026 16:53 View deployment

cursor bot reviewed Jan 23, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/check_run.py Show resolved Hide resolved

Merge branch 'master' into 11_21_debuggability

6d5fd4d

vercel bot deployed to Preview January 26, 2026 20:14 View deployment

Fix typing mismatch

7baaeee

vercel bot deployed to Preview January 26, 2026 20:20 View deployment

Consistency

5304c88

armenzg commented Jan 26, 2026

View reviewed changes

armenzg requested a review from suejung-sentry January 26, 2026 20:37

armenzg marked this pull request as ready for review January 26, 2026 20:37

armenzg requested review from a team as code owners January 26, 2026 20:37

Merge branch 'master' into 11_21_debuggability

b62c3fc

vercel bot deployed to Preview January 26, 2026 21:16 View deployment

Fix tests

5886feb

vercel bot deployed to Preview January 26, 2026 21:28 View deployment

srest2021 reviewed Jan 26, 2026

View reviewed changes

suejung-sentry approved these changes Jan 26, 2026

View reviewed changes

armenzg added 2 commits January 27, 2026 08:04

Move lower

83f8b14

Merge branch 'master' into 11_21_debuggability

d8ebc7a

vercel bot deployed to Preview January 27, 2026 13:07 View deployment

cursor bot reviewed Jan 27, 2026

View reviewed changes

armenzg merged commit db4d290 into master Jan 27, 2026
68 checks passed

armenzg deleted the 11_21_debuggability branch January 27, 2026 14:12

github-actions bot locked and limited conversation to collaborators Feb 12, 2026

Uh oh!

Conversation

armenzg commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

New Function: extract_github_info()

Integration

Testing

Fixtures

Uh oh!

linear bot commented Jan 23, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armenzg commented Jan 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suejung-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

Calling .value on string fails for GitHub Enterprise

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

armenzg commented Jan 23, 2026 •

edited

Loading

New Function: `extract_github_info()`

Calling `.value` on string fails for GitHub Enterprise