fix(trace-waterfall): Add cycle protections#106888
Merged
nsdeschenes merged 9 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Contributor
Author
Contributor
Author
|
@cursor review |
gggritso
approved these changes
Jan 26, 2026
Member
gggritso
left a comment
There was a problem hiding this comment.
Cool, nice work! The PR could use a more detailed description though. Covering why cycles might happen, and what the UI does in case of cycles would be helpful. Actually adding some of that context to the code would be helpful, too.
7ba965e to
63a6ee9
Compare
dashed
pushed a commit
that referenced
this pull request
Jan 26, 2026
This PR makes some changes to the trace tree to add in protection for potential cycles potentially leading infinite loops. In all cases, the UI renders safely with the non-cyclic portion of the tree rather than crashing or hanging. Ticket: EXP-707
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
This PR makes some changes to the trace tree to add in protection for potential cycles potentially leading infinite loops. In all cases, the UI renders safely with the non-cyclic portion of the tree rather than crashing or hanging. Ticket: EXP-707
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
This PR makes some changes to the trace tree to add in protection for potential cycles potentially leading infinite loops. In all cases, the UI renders safely with the non-cyclic portion of the tree rather than crashing or hanging. Ticket: EXP-707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the trace tree to add in protection for potential cycles potentially leading infinite loops.
Ticket: EXP-707
Why cycles might happen
Cycles in trace data can occur from:
parent_span_idreferences create circular dependencies (e.g., span A → B → C → A)What the UI does when cycles are detected
traceTree.tsx)event_idnodes, logs to SentrytransactionNode.tsx)baseNode.tsx)visitedSet to skip already-seen nodesparentAutogroupNode.tsx)In all cases, the UI renders safely with the non-cyclic portion of the tree rather than crashing or hanging.