Skip to content

ref: Use getApiURl() inside of static/app/components/*#106897

Merged
ryan953 merged 7 commits intomasterfrom
ryan953/ref-getApiUrl-app-components
Feb 2, 2026
Merged

ref: Use getApiURl() inside of static/app/components/*#106897
ryan953 merged 7 commits intomasterfrom
ryan953/ref-getApiUrl-app-components

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Jan 23, 2026

@ryan953 ryan953 requested review from a team as code owners January 23, 2026 18:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 23, 2026
The getAttachmentUrl refactor changed how download parameters are handled:
- OLD: URL hardcoded ?download in the string
- NEW: URL is clean, download added via query: {download: true}

When useApiQuery processes {query: {download: true}}, it serializes to
?download=true, not ?download. Tests need to use matchQuery to properly
match query parameters.
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@ryan953 ryan953 merged commit 43e2ac9 into master Feb 2, 2026
57 checks passed
@ryan953 ryan953 deleted the ryan953/ref-getApiUrl-app-components branch February 2, 2026 19:21
shellmayr pushed a commit that referenced this pull request Feb 4, 2026
See: https://gist.github.com/ryan953/af5458fa4f89ae42cc19e8ea266b7e9a

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
See: https://gist.github.com/ryan953/af5458fa4f89ae42cc19e8ea266b7e9a

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants