chore(aci): migration to fix fallthrough_type on email Actions#106902
Merged
chore(aci): migration to fix fallthrough_type on email Actions#106902
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/workflow_engine/migrations/0107_fix_email_action_fallthrough_type.py
Show resolved
Hide resolved
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/workflow_engine/migrations/0107_fix_email_action_fallthrough_type.py
Show resolved
Hide resolved
src/sentry/workflow_engine/migrations/0106_fix_email_action_fallthrough_type.py
Outdated
Show resolved
Hide resolved
cathteng
force-pushed
the
cathy/aci/fallthrough_type-migration
branch
from
d17bf57 to
86a18bc
Compare
src/sentry/workflow_engine/migrations/0106_fix_email_action_fallthrough_type.py
Outdated
Show resolved
Hide resolved
cathteng
force-pushed
the
cathy/aci/fallthrough_type-migration
branch
from
02dc653 to
1c78e3e
Compare
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/sentry/workflow_engine/migrations/0107_fix_email_action_fallthrough_type.py
Outdated
Show resolved
Hide resolved
cathteng
commented
Jan 30, 2026
src/sentry/workflow_engine/migrations/0107_fix_email_action_fallthrough_type.py
Outdated
Show resolved
Hide resolved
armenzg
approved these changes
Feb 2, 2026
ceorourke
approved these changes
Feb 2, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
left some non blocking nits
Comment on lines
+52
to
+56
| if target_type_str in ("Member", "Team"): | ||
| target_identifier = rule_action.get("targetIdentifier") | ||
| config["target_identifier"] = str(target_identifier) if target_identifier else str(None) | ||
| else: | ||
| config["target_identifier"] = None |
Member
There was a problem hiding this comment.
Couldn't you do something like
config["target_identifier"] = str(rule_action.get("targetIdentifier"))
since None is the fallback value and IssueOwners wouldn't have one set?
Comment on lines
+62
to
+65
| fallthrough_type = rule_action.get("fallthrough_type") | ||
| if fallthrough_type is None: | ||
| fallthrough_type = rule_action.get("fallthroughType", DEFAULT_FALLTHROUGH_TYPE) | ||
| data["fallthrough_type"] = str(fallthrough_type) |
Member
There was a problem hiding this comment.
Same here I think you can simplify a bit
fallthrough_type = rule_action.get("fallthrough_type", "fallthroughType")
data["fallthrough_type"] = str(fallthrough_type) if fallthrough_type else DEFAULT_FALLTHROUGH_TYPE
shellmayr
pushed a commit
that referenced
this pull request
Feb 4, 2026
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started handling fallthroughType correctly in dual writing here #106633
But we need a migration to fix the previously migrated email actions