Skip to content

fix(settings): When an org has a disabled github integration we incorrectly detected it as being setup#106910

Merged
ryan953 merged 1 commit intomasterfrom
ryan953/CW-676-disabled-integration-setup-loop
Jan 23, 2026
Merged

fix(settings): When an org has a disabled github integration we incorrectly detected it as being setup#106910
ryan953 merged 1 commit intomasterfrom
ryan953/CW-676-disabled-integration-setup-loop

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Jan 23, 2026

The messages that users see on other pages indicated that they need to re-install the integration. lets check that when we find an integration the status is ready before skipping steps.

On the Integration page we can see these errors:
SCR-20260123-liqr

And we can see from the integration itself that it's in a type of disabled state: disabled by the system (not by the user)
SCR-20260123-lhsx

So we cannot rely on the presence of an integration to mean that things are good. Instead we should check that the integration is good-to-go.

Fixes https://linear.app/getsentry/issue/CW-676/user-feedback-cannot-connect-to-projects-or-organization

…rectly detected it as being setup

The messages that users see on other pages indicated that they need to re-install the integration. lets check that when we find an integration the status is ready before skipping steps.
@ryan953 ryan953 requested a review from a team as a code owner January 23, 2026 20:39
@linear
Copy link

linear bot commented Jan 23, 2026

@ryan953 ryan953 requested a review from billyvg January 23, 2026 20:39
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 23, 2026
@ryan953 ryan953 merged commit 2ce5eda into master Jan 23, 2026
54 checks passed
@ryan953 ryan953 deleted the ryan953/CW-676-disabled-integration-setup-loop branch January 23, 2026 21:10
JonasBa pushed a commit that referenced this pull request Jan 27, 2026
…rectly detected it as being setup (#106910)

The messages that users see on other pages indicated that they need to
re-install the integration. lets check that when we find an integration
the status is ready before skipping steps.

On the Integration page we can see these errors:
<img width="1173" height="407" alt="SCR-20260123-liqr"
src="https://github.com/user-attachments/assets/e68421e4-64da-4bf1-b6aa-ce9f9f965462"
/>


And we can see from the integration itself that it's in a type of
disabled state: disabled by the system (not by the user)
<img width="712" height="266" alt="SCR-20260123-lhsx"
src="https://github.com/user-attachments/assets/bd85a619-76ff-4d3a-b1e7-77b22580d450"
/>

So we cannot rely on the presence of an integration to mean that things
are good. Instead we should check that the integration is good-to-go.

Fixes
https://linear.app/getsentry/issue/CW-676/user-feedback-cannot-connect-to-projects-or-organization
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants