feat(agent): Add alert about other runtimes for meta frameworks#106944
Conversation
…ullstack-option-to-agent-monitoring-onboarding # Conflicts: # static/app/gettingStartedDocs/javascript/agentMonitoring.tsx # static/app/gettingStartedDocs/node/utils.tsx # static/app/views/insights/pages/agents/onboarding.tsx
| /** | ||
| * When used with GuidedSteps component, displays an "Optional" label below the step title. | ||
| */ | ||
| showOptionalLabel?: boolean; |
There was a problem hiding this comment.
I wish this prop was called "optional", but that would likely confuse users since we already have "collapse", which conveys a very similar idea. Might be worth revisiting later.
| // Full-stack JS frameworks that support server-side agent SDKs. | ||
| const fullStackJsPlatforms = [ | ||
| 'javascript-astro', | ||
| 'javascript-nextjs', | ||
| 'javascript-nuxt', | ||
| 'javascript-react-router', | ||
| 'javascript-remix', | ||
| 'javascript-solidstart', | ||
| 'javascript-sveltekit', | ||
| 'javascript-tanstackstart-react', | ||
| ]; |
There was a problem hiding this comment.
we already have this defined in platformCategories
obostjancic
left a comment
There was a problem hiding this comment.
As discussed offline I think the runtime selector could be less prominent, and we maybe don't need it here at all. Most users are on Node so it might be better to keep the in‑product flow focused on that common case and point to the docs for other runtimes. For full‑stack frameworks, AI calls are mostly on the backend, so we could mark the client step as optional or omit it.
…t-monitoring-onboarding
| const selected = | ||
| (params.platformOptions as any)?.integration ?? AgentIntegration.VERCEL_AI; | ||
|
|
||
| if (selected === AgentIntegration.MASTRA) { | ||
| return [ | ||
| { | ||
| type: StepType.INSTALL, |
There was a problem hiding this comment.
In this PR, I separated the install, configure, and verify steps into reusable functions so they could be shared with the full-stack onboarding code. Although I removed the full-stack onboarding changes based on feedback, I decided to keep the separate functions because they improve code readability. It looks like a lot, but the only change really, its the alert for other runtimes in case of meta platforms.
…t-monitoring-onboarding
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
) **Problem** Meta frameworks let the same codebase run in multiple environments - like the browser and the server - and sometimes across different server runtimes. When setting up Sentry to work with Agent Monitoring, users can choose to instrument the client, the server, or both. If they’re using a server runtime other than Node.js (for example, Deno), they must follow the client-side setup for everything to work correctly. Right now, the Agent Monitoring onboarding doesn’t offer client-side instrumentation for meta frameworks, and it doesn’t mention runtimes at all. Both are important, since users might need to configure instrumentation on the client or be running on a non-Node.js runtime. **Solution** We are adding a simple alert inside of the configure section, guiding users to go to the documentation. contributes to https://linear.app/getsentry/issue/TET-1759/split-agent-monitoring-onboarding-into-separate-node-and-browser
Problem
Meta frameworks let the same codebase run in multiple environments - like the browser and the server - and sometimes across different server runtimes.
When setting up Sentry to work with Agent Monitoring, users can choose to instrument the client, the server, or both. If they’re using a server runtime other than Node.js (for example, Deno), they must follow the client-side setup for everything to work correctly.
Right now, the Agent Monitoring onboarding doesn’t offer client-side instrumentation for meta frameworks, and it doesn’t mention runtimes at all. Both are important, since users might need to configure instrumentation on the client or be running on a non-Node.js runtime.
Solution
We are adding a simple alert inside of the configure section, guiding users to go to the documentation.
contributes to https://linear.app/getsentry/issue/TET-1759/split-agent-monitoring-onboarding-into-separate-node-and-browser