ref(preprod): Rename preprod settings page to mobile builds#106964
ref(preprod): Rename preprod settings page to mobile builds#106964
Conversation
| path: 'builds/', | ||
| name: t('Mobile Builds'), |
There was a problem hiding this comment.
Bug: The backend function _get_settings_url generates a URL with the old /preprod/ path, but the frontend route was changed to /builds/, which will cause broken links.
Severity: HIGH
Suggested Fix
Update the _get_settings_url function in src/sentry/preprod/vcs/status_checks/size/templates.py to use the new /builds/ path instead of /preprod/. Also, update the corresponding tests in tests/sentry/preprod/vcs/status_checks/size/test_templates.py to assert against the correct new URL.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/router/routes.tsx#L686-L687
Potential issue: The frontend route for project settings was changed from `/preprod/` to
`/builds/`. However, the backend function `_get_settings_url` in
`src/sentry/preprod/vcs/status_checks/size/templates.py` still hardcodes the old
`/preprod/` path when generating URLs for VCS status check comments. This discrepancy
means that links in GitHub PR comments, intended to direct users to the settings page,
will point to a non-existent URL, resulting in a 404 error for the user. The associated
tests also use the outdated URL, which is why this issue was not caught.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| path: 'preprod/', | ||
| name: t('Preprod'), | ||
| path: 'builds/', | ||
| name: t('Mobile Builds'), |
There was a problem hiding this comment.
Missing redirect from old route path to new path
Medium Severity
The route path changed from preprod/ to builds/ without adding a redirect from the old path. Users who have bookmarked /settings/.../projects/.../preprod/ or have shared links to that URL will get 404 errors. The codebase has an established pattern of adding redirects when routes are renamed (e.g., csp/ → security-headers/csp/, dynamic-sampling/ → performance/). A redirect entry like { path: 'preprod/', redirectTo: 'builds/' } is missing.
There was a problem hiding this comment.
Should we add a redirect?
Backend part of #106964
No description provided.