Skip to content

ref(preprod): Rename preprod settings page to mobile builds#106964

Merged
chromy merged 1 commit intomasterfrom
chromy/2026-01-27-change-settings
Jan 26, 2026
Merged

ref(preprod): Rename preprod settings page to mobile builds#106964
chromy merged 1 commit intomasterfrom
chromy/2026-01-27-change-settings

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Jan 26, 2026

No description provided.

@chromy chromy requested a review from a team as a code owner January 26, 2026 14:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 26, 2026
Comment on lines +686 to +687
path: 'builds/',
name: t('Mobile Builds'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The backend function _get_settings_url generates a URL with the old /preprod/ path, but the frontend route was changed to /builds/, which will cause broken links.
Severity: HIGH

Suggested Fix

Update the _get_settings_url function in src/sentry/preprod/vcs/status_checks/size/templates.py to use the new /builds/ path instead of /preprod/. Also, update the corresponding tests in tests/sentry/preprod/vcs/status_checks/size/test_templates.py to assert against the correct new URL.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/router/routes.tsx#L686-L687

Potential issue: The frontend route for project settings was changed from `/preprod/` to
`/builds/`. However, the backend function `_get_settings_url` in
`src/sentry/preprod/vcs/status_checks/size/templates.py` still hardcodes the old
`/preprod/` path when generating URLs for VCS status check comments. This discrepancy
means that links in GitHub PR comments, intended to direct users to the settings page,
will point to a non-existent URL, resulting in a 404 error for the user. The associated
tests also use the outdated URL, which is why this issue was not caught.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

path: 'preprod/',
name: t('Preprod'),
path: 'builds/',
name: t('Mobile Builds'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing redirect from old route path to new path

Medium Severity

The route path changed from preprod/ to builds/ without adding a redirect from the old path. Users who have bookmarked /settings/.../projects/.../preprod/ or have shared links to that URL will get 404 errors. The codebase has an established pattern of adding redirects when routes are renamed (e.g., csp/security-headers/csp/, dynamic-sampling/performance/). A redirect entry like { path: 'preprod/', redirectTo: 'builds/' } is missing.

Fix in Cursor Fix in Web

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a redirect?

@chromy chromy merged commit 7e4ebc0 into master Jan 26, 2026
54 checks passed
@chromy chromy deleted the chromy/2026-01-27-change-settings branch January 26, 2026 14:32
chromy added a commit that referenced this pull request Jan 26, 2026
dashed pushed a commit that referenced this pull request Jan 26, 2026
dashed pushed a commit that referenced this pull request Jan 26, 2026
JonasBa pushed a commit that referenced this pull request Jan 27, 2026
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants