Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/preprod/vcs/status_checks/size/templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def _get_settings_url(
triggered_rules: list[TriggeredRule] | None = None,
) -> str:
"""Build the settings URL for the project's preprod settings page."""
base_url = f"/settings/projects/{project.slug}/builds/"
base_url = f"/settings/projects/{project.slug}/mobile-builds/"
if triggered_rules:
expanded_params = "&".join(f"expanded={tr.rule.id}" for tr in triggered_rules)
return project.organization.absolute_url(base_url, query=expanded_params)
Expand Down
2 changes: 1 addition & 1 deletion static/app/router/routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ function buildRoutes(): RouteObject[] {
component: make(() => import('sentry/views/settings/project/tempest')),
},
{
path: 'builds/',
path: 'mobile-builds/',
name: t('Mobile Builds'),
component: make(() => import('sentry/views/settings/project/preprod')),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
size="sm"
icon={<IconSettings />}
aria-label={t('Settings')}
to={`/settings/${organization.slug}/projects/${projectId}/builds/`}
to={`/settings/${organization.slug}/projects/${projectId}/mobile-builds/`}
/>
</Feature>
<ConfirmDelete
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/preprod/buildList/buildList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default function BuildList() {
size="sm"
icon={<IconSettings />}
aria-label={t('Settings')}
to={`/settings/${organization.slug}/projects/${projectId}/builds/`}
to={`/settings/${organization.slug}/projects/${projectId}/mobile-builds/`}
/>
</Feature>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default function getConfiguration({
show: () => !!(organization && hasTempestAccess(organization)) && !isSelfHosted,
},
{
path: `${pathPrefix}/builds/`,
path: `${pathPrefix}/mobile-builds/`,
title: t('Mobile Builds'),
show: () => !!organization?.features?.includes('preprod-issues'),
badge: () => 'beta',
Expand Down
14 changes: 5 additions & 9 deletions tests/sentry/preprod/vcs/status_checks/size/test_templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ def test_mixed_platforms_render_separate_tables(self):

android_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{android_artifact.id}?project={self.project.slug}"
ios_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{ios_artifact.id}?project={self.project.slug}"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/"

expected = f"""\
## 2 Apps Analyzed
Expand Down Expand Up @@ -1127,9 +1127,7 @@ def test_single_triggered_rule_shows_details_section(self):
)

artifact_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}?project={self.project.slug}"
settings_url = (
f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1"
)
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"

expected = f"""\
## ❌ 1 App Failed Size Checks
Expand Down Expand Up @@ -1224,7 +1222,7 @@ def test_multiple_triggered_rules_url_formatting(self):
)

artifact_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}?project={self.project.slug}"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"

expected = f"""\
## ❌ 1 App Failed Size Checks
Expand Down Expand Up @@ -1331,7 +1329,7 @@ def test_multiple_apps_with_triggered_rules(self):

artifact1_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact1.id}?project={self.project.slug}"
artifact2_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact2.id}?project={self.project.slug}"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1&expanded=rule-2"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1&expanded=rule-2"

expected = f"""\
## ❌ 2 Apps Failed Size Checks
Expand Down Expand Up @@ -1434,9 +1432,7 @@ def test_mixed_pass_fail_with_triggered_rules(self):

failed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{failed_artifact.id}?project={self.project.slug}"
passed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{passed_artifact.id}?project={self.project.slug}"
settings_url = (
f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1"
)
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"

expected = f"""\
## ❌ 1 App Failed Size Checks
Expand Down
Loading