chore(preprod): Show neutral status checks if no rules, otherwise show actual states#107014
Merged
NicoHinderling merged 2 commits intomasterfrom Jan 27, 2026
Conversation
trevor-e
approved these changes
Jan 26, 2026
| if status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE): | ||
| # Only convert to neutral when no rules are configured. | ||
| # When rules exist, show actual status (in_progress, failure, success). | ||
| if not rules and status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE): |
Member
There was a problem hiding this comment.
Is status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE) even still needed?
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
…w actual states (#107014)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.