Skip to content

chore(preprod): Show neutral status checks if no rules, otherwise show actual states#107014

Merged
NicoHinderling merged 2 commits intomasterfrom
show-neutral-status-checks-if-no-rules-otherwise-show-fail-success
Jan 27, 2026
Merged

chore(preprod): Show neutral status checks if no rules, otherwise show actual states#107014
NicoHinderling merged 2 commits intomasterfrom
show-neutral-status-checks-if-no-rules-otherwise-show-fail-success

Conversation

@NicoHinderling
Copy link
Contributor

No description provided.

@NicoHinderling NicoHinderling requested a review from a team as a code owner January 26, 2026 21:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2026
if status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE):
# Only convert to neutral when no rules are configured.
# When rules exist, show actual status (in_progress, failure, success).
if not rules and status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is status in (StatusCheckStatus.IN_PROGRESS, StatusCheckStatus.FAILURE) even still needed?

@NicoHinderling NicoHinderling merged commit c45be47 into master Jan 27, 2026
70 checks passed
@NicoHinderling NicoHinderling deleted the show-neutral-status-checks-if-no-rules-otherwise-show-fail-success branch January 27, 2026 17:03
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants