fix(ui): streamline colors for groupStatusChart#107044
Merged
Conversation
and switch to `theme.tokens.dataviz` palette
github-actions
bot
added
the
Scope: Frontend
Jesse-Box
approved these changes
Jan 27, 2026
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
and switch to `theme.tokens.dataviz` palette for the grey, we now always use `theme.tokens.dataviz.semantic.other`, not matter if only one bar chart series is shown or two. For the matching bar chart, we use `theme.tokens.dataviz.semantic.accent`. From what I can tell, contrast is getting better in light mode but worse in dark mode. before: | Events Light | Events Dark | Total/Matching Light | Total/Matching Dark | |--------|--------|--------|--------| | <img width="346" height="268" alt="Screenshot 2026-01-27 at 13 02 40" src="https://github.com/user-attachments/assets/aa59aa9d-c3b7-441f-bc17-19ca53dc9093" /> | <img width="337" height="265" alt="Screenshot 2026-01-27 at 13 02 47" src="https://github.com/user-attachments/assets/8f128fb4-3c88-4a1e-aa36-d05db38ca6d9" /> | <img width="325" height="278" alt="Screenshot 2026-01-27 at 13 01 34" src="https://github.com/user-attachments/assets/d193bbc1-f1e1-42e1-b406-b38eb3e92882" /> | <img width="332" height="273" alt="Screenshot 2026-01-27 at 13 01 25" src="https://github.com/user-attachments/assets/a91a06c2-99c1-41e1-828a-ab5b7e873c70" /> | after: | Events Light | Events Dark | Total/Matching Light | Total/Matching Dark | |--------|--------|--------|--------| | <img width="362" height="270" alt="Screenshot 2026-01-27 at 13 03 45" src="https://github.com/user-attachments/assets/7be4429b-f951-4747-a644-169042707fd5" /> | <img width="353" height="269" alt="Screenshot 2026-01-27 at 13 03 52" src="https://github.com/user-attachments/assets/e8844169-ff0d-482e-9ca7-71b058e6d78c" /> | <img width="339" height="277" alt="Screenshot 2026-01-27 at 13 03 31" src="https://github.com/user-attachments/assets/aa839fd9-7a20-407d-bce2-30c26b003184" /> | <img width="347" height="271" alt="Screenshot 2026-01-27 at 13 03 25" src="https://github.com/user-attachments/assets/9f7b6a38-b123-47f5-a29a-7a55ce125384" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and switch to
theme.tokens.datavizpalettefor the grey, we now always use
theme.tokens.dataviz.semantic.other, not matter if only one bar chart series is shown or two. For the matching bar chart, we usetheme.tokens.dataviz.semantic.accent.From what I can tell, contrast is getting better in light mode but worse in dark mode.
before:
after: