ref(dashboards): Migrate mobileAppSize to React Query hooks#107062
Merged
DominikB2014 merged 3 commits intomasterfrom Jan 27, 2026
Merged
Conversation
Migrates the mobileAppSize dataset configuration from Promise-based API calls to React Query hook-based data fetching. Changes: - Create useMobileAppSizeWidgetQuery.tsx with useSeriesQuery/useTableQuery hooks - Update MobileAppSizeConfig to use new hooks instead of getSeriesRequest - Add proper error extraction from API responses (responseJSON.detail) - Support widget query queueing with async queue feature - Add sampling mode support - Remove obsolete getSeriesRequest test cases - All 94 tests pass The table query is a placeholder that returns empty data since MobileAppSize only supports line chart visualizations.
Contributor
Author
|
@cursor review |
…leappsize-dataset-to-hook-pattern
trevor-e
approved these changes
Jan 27, 2026
Member
trevor-e
left a comment
There was a problem hiding this comment.
Tested on my local data and seems to work alright! My main question is around the duplication going on across dataset fetching but I assume your team has a plan around that.
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
Migrates the mobileAppSize dataset configuration from Promise-based API calls to React Query hook-based data fetching. The `useSeriesQuery` and `useTableQuery` will replace the old `getSeriesRequest` and `getTableRequest` in the config. There's some duplication here between other dataset hooks, the plan is to extract shared functionality once all datasets are migrated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the mobileAppSize dataset configuration from Promise-based API calls to React Query hook-based data fetching. The
useSeriesQueryanduseTableQuerywill replace the oldgetSeriesRequestandgetTableRequestin the config.There's some duplication here between other dataset hooks, the plan is to extract shared functionality once all datasets are migrated.