Skip to content

feat(preprod): Fix platform_name handling#107103

Merged
NicoHinderling merged 3 commits intomasterfrom
chromy/2026-01-26-fix-platform-name
Jan 27, 2026
Merged

feat(preprod): Fix platform_name handling#107103
NicoHinderling merged 3 commits intomasterfrom
chromy/2026-01-26-fix-platform-name

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Jan 27, 2026

Previously we had two issues:

  • EAP and Postgres disagreed on the values for platform_name {android,ios} vs {android,apple} this caused issues with structured search (since EAP provides auto-fill but postgres backs the search.
  • platform_name had a special implementation which was fragile.

Fix both of these by adding another annotation which a) matches EAP and b) lets us treat platform_name as just another string.

@chromy chromy requested a review from a team as a code owner January 27, 2026 21:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 27, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@NicoHinderling NicoHinderling force-pushed the chromy/2026-01-26-fix-platform-name branch from 1afe0b7 to 1a92b8f Compare January 27, 2026 21:41
@NicoHinderling NicoHinderling merged commit 2cd9976 into master Jan 27, 2026
70 checks passed
@NicoHinderling NicoHinderling deleted the chromy/2026-01-26-fix-platform-name branch January 27, 2026 22:07
priscilawebdev pushed a commit that referenced this pull request Jan 28, 2026
Previously we had two issues:
- EAP and Postgres disagreed on the values for `platform_name`
{`android`,`ios`} vs {`android`,`apple`} this caused issues with
structured search (since EAP provides auto-fill but postgres backs the
search.
- `platform_name` had a special implementation which was fragile.

Fix both of these by adding another annotation which a) matches EAP and
b) lets us treat `platform_name` as just another string.

---------

Co-authored-by: Nico Hinderling <NicoHinderling@users.noreply.github.com>
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
Previously we had two issues:
- EAP and Postgres disagreed on the values for `platform_name`
{`android`,`ios`} vs {`android`,`apple`} this caused issues with
structured search (since EAP provides auto-fill but postgres backs the
search.
- `platform_name` had a special implementation which was fragile.

Fix both of these by adding another annotation which a) matches EAP and
b) lets us treat `platform_name` as just another string.

---------

Co-authored-by: Nico Hinderling <NicoHinderling@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants