Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
01-27-chore_preprod_fe_update_build_details_platform_code_to_support_apple_value
branch
from
a8ba919 to
cc79aa8
Compare
NicoHinderling
force-pushed
the
01-27-chore_preprod_fe_update_build_details_platform_code_to_support_apple_value
branch
from
cc79aa8 to
669b4f3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
01-27-chore_preprod_fe_update_build_details_platform_code_to_support_apple_value
branch
from
669b4f3 to
00fcb5b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| aria-label={t('Install QR Code')} | ||
| value={ | ||
| installDetails.platform === 'ios' | ||
| installDetails.platform === 'ios' || installDetails.platform === 'apple' |
There was a problem hiding this comment.
Apple platform treated as iOS installs
Medium Severity
The QR code value uses the iOS itms-services:// scheme when installDetails.platform is apple. If apple can represent macOS artifacts as well as iOS, scanning the QR code may produce an invalid install flow by forcing the iOS manifest scheme for non-iOS platforms.
|
|
||
| function getInsightsDocsUrl(platform?: Platform): string { | ||
| if (platform === 'macos' || platform === 'ios') { | ||
| if (platform === 'apple' || platform === 'macos' || platform === 'ios') { |
There was a problem hiding this comment.
Apple insights docs link points to iOS
Low Severity
getInsightsDocsUrl returns the iOS Apple docs URL when platform is apple. If apple is a generic value (not specifically iOS), this can send users to the wrong documentation (e.g., macOS-specific guidance).
NicoHinderling
force-pushed
the
01-27-chore_preprod_fe_update_build_details_platform_code_to_support_apple_value
branch
from
00fcb5b to
0160fef
Compare
chromy
deleted the
01-27-chore_preprod_fe_update_build_details_platform_code_to_support_apple_value
branch
2 participants
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.