Conversation
github-actions
bot
added
the
Scope: Backend
leeandher
force-pushed
the
leanderrodrigues/iswf-1179-investigate-how-complicated-it-would-be-to-hook-into
branch
from
6a23a96 to
22d592b
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
0c09cb8 to
602e629
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
602e629 to
dda0e47
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
dda0e47 to
9619858
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
9619858 to
74ab73a
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
74ab73a to
b46ad65
Compare
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
b46ad65 to
4f6016a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
GabeVillalobos
approved these changes
Jan 29, 2026
Base automatically changed from
leanderrodrigues/iswf-1179-investigate-how-complicated-it-would-be-to-hook-into
to
master
January 29, 2026 21:11
Add SeerOperator.has_access() method to centralize permission checks for Seer workflows. This replaces direct feature flag checks with a unified approach that validates both Seer access and entrypoint-specific permissions. Key changes: - Add SeerOperator.has_access() class method with optional entrypoint_key - Add has_access() static method to SeerEntrypoint protocol - Implement has_access() in SlackEntrypoint using feature flag - Replace feature flag checks with SeerOperator.has_access() calls - Update tests to mock has_seer_access for proper isolation Co-Authored-By: Claude <noreply@anthropic.com>
Cast the entrypoint_key to SeerEntrypointKey in the has_access test to satisfy type checker requirements. Co-Authored-By: Claude <noreply@anthropic.com>
leeandher
force-pushed
the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
from
57fd85b to
7b2248c
Compare
…Cache Rename cache key generation and retrieval methods to private (underscore prefix) to clarify the public API. The public interface now consists of get(), populate_pre_autofix_cache(), populate_post_autofix_cache(), and migrate_pre_autofix_cache(). Also add docstring to the get() method.
leeandher
deleted the
leanderrodrigues/iswf-1943-ensure-correct-permission-checks-for-displaying-seer-in
branch
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
…107173) adding `SeerOperator.has_access()` and entrypoint versions too. - the operator version checks for seer access + access to any entrypoint (which checks the entry point version) - most app code that invokes the operator uses this check - app code that needs to check a single entrypoint still can, but ALSO gets seer checks now 👍 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding
SeerOperator.has_access()and entrypoint versions too.