chore(eslint): fix type checking#107190
Merged
natemoo-re merged 6 commits intomasterfrom Jan 29, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
natemoo-re
force-pushed
the
scraps/lint/tsc
branch
from
5e83b16 to
d336fdd
Compare
natemoo-re
force-pushed
the
scraps/lint/tsc
branch
from
89a22c6 to
e9b336b
Compare
scttcper
reviewed
Jan 28, 2026
static/eslint/eslintPluginScraps/src/rules/use-semantic-token.mjs
Outdated
Show resolved
Hide resolved
scttcper
approved these changes
Jan 28, 2026
Member
I'm a bit afraid that we'll break this again in the future without knowing, and we'll be back to where we started :) |
natemoo-re
changed the title
Member
Author
natemoo-re
force-pushed
the
scraps/lint/tsc
branch
from
e9b336b to
fa6adb4
Compare
Member
Yeah, you are not wrong, it's just that we can't do that in practice (unless we make it non required) as it's not stable yet. If we make it a non required check, then I think thats probably a good way to go, but we should monitor if it starts to create a lot of noise |
JonasBa
approved these changes
Jan 29, 2026
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
Follow-up to #107187, which added `// @ts-nocheck` The violations were removed in #107212. I originally tried configuring `tsconfig` to include only `static/eslint/eslintPluginSentry`, but the `eslint.config.mjs` file is typechecked so `static/eslint/eslintPluginScraps` gets included regardless Since `pnpm run typecheck` passes, we can enable type checking again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #107187, which added
// @ts-nocheckThe violations were removed in #107212.
I originally tried configuring
tsconfigto include onlystatic/eslint/eslintPluginSentry, but theeslint.config.mjsfile is typechecked sostatic/eslint/eslintPluginScrapsgets included regardlessSince
pnpm run typecheckpasses, we can enable type checking again.