ref(grouping): Small message parameterization refactors#107201
Merged
lobsterkatie merged 8 commits intomasterfrom Jan 28, 2026
Merged
ref(grouping): Small message parameterization refactors#107201lobsterkatie merged 8 commits intomasterfrom
lobsterkatie merged 8 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
mrduncan
approved these changes
Jan 28, 2026
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
This includes a number of small refactors to message parameterization (primarily to tests), extracted from an upcoming PR to make it easier to review. No behavior changes. - Clarify comment describing our hex parameterization. - Expand hex test cases and give them clearer names. - Clarify traceparent case. - Reverse assertions so they're `result == expected` rather than `expected == result`. The same to the computer, but more logical for how humans talk about what's actually being tested. - Fix tests so each one tests four different cases (all combos of having or not having a prefix and suffix in the parameterized string) rather than the same case (no prefix or suffix) four times. - Make `xfail` in tests strict. - Remove unnecessary "Case x failed" statements, since parameterization does that for us. - Fix typo in test description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a number of small refactors to message parameterization (primarily to tests), extracted from an upcoming PR to make it easier to review. No behavior changes.
result == expectedrather thanexpected == result. The same to the computer, but more logical for how humans talk about what's actually being tested.xfailin tests strict.