Skip to content

feat(preprod): Unhide filters#107232

Merged
chromy merged 1 commit intomasterfrom
chromy/2026-01-29-unhide-filters
Jan 29, 2026
Merged

feat(preprod): Unhide filters#107232
chromy merged 1 commit intomasterfrom
chromy/2026-01-29-unhide-filters

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Jan 29, 2026

For now restrict attributes to those that a know to available at checking time:

  • build_configuration_name
  • git_head_ref
  • git_base_ref
  • git_head_sha
  • git_base_sha
  • git_head_repo_name
  • git_pr_number

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 29, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

'Build Distribution helps you securely distribute iOS builds to your internal teams and beta testers. Streamline your distribution workflow with automated uploads from CI.'
)}
</Text>
</FeatureFilter>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build Distribution feature flag requirement unintentionally loosened

Medium Severity

The Build Distribution FeatureFilter was previously nested inside both organizations:preprod-issues and organizations:preprod-build-distribution feature flags, requiring both to be enabled. After this change, it's only gated by preprod-build-distribution. This means users who have preprod-build-distribution but not preprod-issues will now see the Build Distribution filter when they previously could not. This may be an unintended side effect of removing the outer Feature wrapper.

Fix in Cursor Fix in Web

@chromy chromy merged commit 119eb55 into master Jan 29, 2026
55 checks passed
@chromy chromy deleted the chromy/2026-01-29-unhide-filters branch January 29, 2026 14:11
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
For now restrict attributes to those that a know to available at
checking time:
- build_configuration_name
- git_head_ref
- git_base_ref
- git_head_sha
- git_base_sha
- git_head_repo_name
- git_pr_number
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants