fix: improve seer automation endpoint#107235
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
bruno-garcia
approved these changes
Jan 29, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Update repository validation in both endpoints to handle provider format mismatch between API requests (e.g., "github") and database storage (e.g., "integrations:github"). Also adds ObjectStatus.ACTIVE filter to exclude deleted repositories.
JoshFerge
force-pushed
the
jferg/seer-automation-improvements
branch
from
372d2cf to
363100b
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
## Summary Improve repository validation in Seer automation endpoints to fix IDOR vulnerabilities and provider format handling. ### Changes 1. **IDOR fix for `OrganizationAutofixAutomationSettingsEndpoint`** - Validates that repositories in `projectRepoMappings` exist and belong to the organization before processing 2. **Provider format handling** - Updates repository validation in both endpoints to handle the mismatch between API requests (e.g., `"github"`) and database storage (e.g., `"integrations:github"`) using Q objects with OR conditions 3. **Active status filter** - Adds `status=ObjectStatus.ACTIVE` to exclude deleted repositories from validation ### Files Modified - `src/sentry/seer/endpoints/organization_autofix_automation_settings.py` - `src/sentry/seer/endpoints/project_seer_preferences.py`
billyvg
added a commit
that referenced
this pull request
Feb 5, 2026
I missed that this was broken recently due to a backend change: #107235 id === `integrations:${provider.name.toLowerCase}`, so changing what we send to `provider` may break other things, so change it back to use name
billyvg
added a commit
that referenced
this pull request
Feb 9, 2026
I missed that this was broken recently due to a backend change: #107235 -- specifically [here](https://github.com/getsentry/sentry/pull/107235/changes#diff-069c881c439f4ff7260f1e9bad598201a9b4798611320656c675571d640a5a2fR258) id === `integrations:${provider.name.toLowerCase}`, so changing what we send as `provider` may break other things, so change it back to use provider.name
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
I missed that this was broken recently due to a backend change: #107235 -- specifically [here](https://github.com/getsentry/sentry/pull/107235/changes#diff-069c881c439f4ff7260f1e9bad598201a9b4798611320656c675571d640a5a2fR258) id === `integrations:${provider.name.toLowerCase}`, so changing what we send as `provider` may break other things, so change it back to use provider.name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
various improvments