Skip to content

chore(code_review): Remove non-validated payloads path#107237

Merged
armenzg merged 4 commits intomasterfrom
cursor/seer-webhook-validation-option-69e9
Jan 30, 2026
Merged

chore(code_review): Remove non-validated payloads path#107237
armenzg merged 4 commits intomasterfrom
cursor/seer-webhook-validation-option-69e9

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Jan 29, 2026

Removes the seer.code_review.validate_webhook_payload option and only support the payload validation path.

@cursor
Copy link
Contributor

cursor bot commented Jan 29, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 29, 2026
@armenzg armenzg closed this Jan 29, 2026
@armenzg armenzg reopened this Jan 29, 2026
@armenzg armenzg changed the title Seer webhook validation option chore(code_review): Remove non-validated payloads path Jan 29, 2026
@armenzg armenzg self-assigned this Jan 29, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

armenzg

This comment was marked as off-topic.

@armenzg armenzg marked this pull request as ready for review January 29, 2026 15:18
@armenzg armenzg requested a review from a team as a code owner January 29, 2026 15:18
@armenzg armenzg enabled auto-merge (squash) January 29, 2026 15:18
cursoragent and others added 3 commits January 30, 2026 09:42
- Remove option registration from defaults.py
- Remove validation logic from webhook task handler
- Remove validation-related tests
- Simplify webhook payload processing to always pass through without Pydantic validation

Co-authored-by: armenzg <armenzg@sentry.io>
Co-authored-by: armenzg <armenzg@sentry.io>
- Restore Pydantic validation for webhook payloads (always enabled)
- Remove conditional check for seer.code_review.validate_webhook_payload option
- Restore validation tests (without @override_options decorator)
- Validation now always runs for PR review/closed events (not CHECK_RUN)

Co-authored-by: armenzg <armenzg@sentry.io>
@armenzg armenzg force-pushed the cursor/seer-webhook-validation-option-69e9 branch from a91517b to 4bb1cd1 Compare January 30, 2026 14:44
@armenzg armenzg disabled auto-merge January 30, 2026 14:45
@armenzg armenzg enabled auto-merge (squash) January 30, 2026 14:45
@armenzg armenzg merged commit af90a95 into master Jan 30, 2026
66 checks passed
@armenzg armenzg deleted the cursor/seer-webhook-validation-option-69e9 branch January 30, 2026 17:53
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
Removes the `seer.code_review.validate_webhook_payload` option and only
support the payload validation path.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants