chore(dashboards): Explain when we use base 10 vs. base 2 formatting for size data#107298
Merged
chore(dashboards): Explain when we use base 10 vs. base 2 formatting for size data#107298
Conversation
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
approved these changes
Jan 29, 2026
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
…for size data (#107298) Add a little code comment to explain the consequences of editing `ABYTE_UNITS`, since I don't think the impact there is clear. Maybe it's worth to update the code to make this even more explicit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a little code comment to explain the consequences of editing
ABYTE_UNITS, since I don't think the impact there is clear. Maybe it's worth to update the code to make this even more explicit?