feat(issues): Hide package and address for non-native frames in mixed stacktraces #107318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stacktraces In mixed stacktraces, native attributes like package names and instruction addresses are not meaningful for non-native frames (Java, Kotlin, JavaScript). This conditionally hides these attributes based on frame.platform, ensuring cleaner display in Android NDK and similar mixed-platform stacktraces.
github-actions
bot
added
the
Scope: Frontend
Update getStacktracePlatform to prioritize the event platform when present in any frame, before falling back to the first frame with a different platform. This ensures native information (package and address) is only shown for truly native frames in mixed stacktraces. Restructure nativeFrame layout to consistently wrap native-specific elements, making the conditional rendering logic clearer and more maintainable. Add test coverage for the updated platform detection logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mixed stacktraces (e.g., Android NDK with both native and Java/Kotlin frames), native-specific attributes like package names and instruction addresses are not meaningful for non-native frames and add visual clutter.
This change conditionally displays these attributes based on the frame's platform. The
frame.platformproperty takes precedence over the event platform when determining whether to show native debugging information, ensuring that Java, Kotlin, and JavaScript frames display cleanly without confusing native-only details.Changes:
isNativePlatform()utility to identify native platformsNativeFramecomponent