Skip to content

fix(dashboards): bring selected option to top of visualize dropdown#107355

Merged
nikkikapadia merged 6 commits intomasterfrom
nikki/fix/visualize-selected-ordering
Feb 4, 2026
Merged

fix(dashboards): bring selected option to top of visualize dropdown#107355
nikkikapadia merged 6 commits intomasterfrom
nikki/fix/visualize-selected-ordering

Conversation

@nikkikapadia
Copy link
Member

closes https://linear.app/getsentry/issue/DAIN-389/changes-to-visualize-dropdowns

The widget builder visualize dropdowns did not have the selected option in view when re-opening the dropdown. This PR moves the selected option to the top of the dropdown list so that users can see what they have selected in the list.

Note: I haven't done this for the metrics dropdown because the dropdown component is reused from the Metrics UI and I didn't want to make changes to that yet.

@linear
Copy link

linear bot commented Jan 30, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 30, 2026
@nikkikapadia nikkikapadia marked this pull request as ready for review January 30, 2026 19:50
@nikkikapadia nikkikapadia requested a review from a team as a code owner January 30, 2026 19:50
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but IMO you should reach out to the Design Engineering team, and ask them if this should be implemented as part of CompactSelect. I think floating the selected values to the top might be better as a component-level behaviour. We do this in multiple places and it'd be good if it was shared

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@nikkikapadia nikkikapadia merged commit 6839412 into master Feb 4, 2026
59 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/visualize-selected-ordering branch February 4, 2026 15:25
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
…107355)

closes
https://linear.app/getsentry/issue/DAIN-389/changes-to-visualize-dropdowns

The widget builder visualize dropdowns did not have the selected option
in view when re-opening the dropdown. This PR moves the selected option
to the top of the dropdown list so that users can see what they have
selected in the list.

Note: I haven't done this for the metrics dropdown because the dropdown
component is reused from the Metrics UI and I didn't want to make
changes to that yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants