-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(lint): address theme.tokens.background violations
#107451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98ba8d4 to
7352785
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
static/app/views/performance/transactionSummary/transactionEvents/operationSort.tsx
Outdated
Show resolved
Hide resolved
static/app/views/insights/browser/webVitals/components/performanceScoreRingWithTooltips.tsx
Outdated
Show resolved
Hide resolved
8a76bfc to
dd1d11e
Compare
fixes background token violations to prepare for enabling @sentry/scraps/use-semantic-token rule for background category blocking #<TBD>
- Fix border.accent object bug (was rendering [object Object]) - Revert arrow fills to background.primary with eslint-disable comments for CSS border-based triangles that need to match their container
5ac7dc4 to
8f70268
Compare
JonasBa
approved these changes
Feb 5, 2026
natemoo-re
added a commit
that referenced
this pull request
Feb 5, 2026
enable `@sentry/scraps/use-semantic-token` rule for `theme.tokens.background` blocked by #107451, closes DE-782 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
scttcper
added a commit
that referenced
this pull request
Feb 10, 2026
reverts a change from #107451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
theme.tokens.backgroundviolationsblocking #107452
TODO
background-image