chore(processing-errors): Add more detail to processing error analytics#107466
chore(processing-errors): Add more detail to processing error analytics#107466
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
wedamija
force-pushed
the
danf/proc-errors-more-info
branch
from
dd34f61 to
3cc8fba
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| error_type = error.get("type", "unknown") | ||
| try: | ||
| error_type = error.get("type", "unknown") | ||
| error_name = error.get("name") |
There was a problem hiding this comment.
Missing type conversion for error_name unlike error_value
Low Severity
The code converts error_value to a JSON string if it's not already a string (lines 1138-1141), but error_name is passed directly to the analytics event without any type conversion. Existing code in src/sentry/api/serializers/models/event.py explicitly checks if not isinstance(name, str), indicating that name can be non-string. If error_name is a non-string value, it would violate the name: str | None type annotation in EventProcessingErrorRecorded, potentially causing type mismatches or unexpected serialization behavior.
…cs (#107466) Including the name/value fields so that we can get more details about processing errors like `invalid-attribute`, etc. <!-- Describe your PR here. -->
2 participants
Including the name/value fields so that we can get more details about processing errors like
invalid-attribute, etc.