ref(grouping): Make Windows multiprocess grouping inputs more realistic#107561
Merged
lobsterkatie merged 2 commits intomasterfrom Feb 5, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
cvxluo
approved these changes
Feb 4, 2026
lobsterkatie
deleted the
kmclb-make-windows-multiprocess-grouping-inputs-more-realistic
branch
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…ic (#107561) When we added grouping test inputs for the windows version of hard-coded values in multiprocessing calls[1], we did so using posix stacktraces, because that's the only examples we had. Each input therefore included the following entry: ``` "TODO": "The stack here is really a posix stack, not a Windows stack; the only thing Windows-y about this is the arguments passed to 'spawn_main' in the first frame. Admittedly that line is the whole point of having this input - the rest is sort of beside the point - but still, it would be nice to make this more realistic. Once the code for handling python multiprocessing context lines is in prod and we start logging instances of this in projects other than our own internal sentry project, it would be good to find an example which actually is from Windows, and use that to fix this stacktrace.", ``` We've since seen a few events come in from actual Windows machines, so we can now handle the aforementioned task. (Note: This uses data from a customer event for structure, but all in-app function names, code lines, and filepaths have been changed, as has the error message - only frames from the third-party server framework and from Python itself have been used as is.) [1] #103185
dcramer
pushed a commit
that referenced
this pull request
Feb 17, 2026
…ic (#107561) When we added grouping test inputs for the windows version of hard-coded values in multiprocessing calls[1], we did so using posix stacktraces, because that's the only examples we had. Each input therefore included the following entry: ``` "TODO": "The stack here is really a posix stack, not a Windows stack; the only thing Windows-y about this is the arguments passed to 'spawn_main' in the first frame. Admittedly that line is the whole point of having this input - the rest is sort of beside the point - but still, it would be nice to make this more realistic. Once the code for handling python multiprocessing context lines is in prod and we start logging instances of this in projects other than our own internal sentry project, it would be good to find an example which actually is from Windows, and use that to fix this stacktrace.", ``` We've since seen a few events come in from actual Windows machines, so we can now handle the aforementioned task. (Note: This uses data from a customer event for structure, but all in-app function names, code lines, and filepaths have been changed, as has the error message - only frames from the third-party server framework and from Python itself have been used as is.) [1] #103185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added grouping test inputs for the windows version of hard-coded values in multiprocessing calls, we did so using posix stacktraces, because that's the only examples we had. Each input therefore included the following entry:
We've since seen a few events come in from actual Windows machines, so we can now handle the aforementioned task. (Note: This uses data from a customer event for structure, but all in-app function names, code lines, and filepaths have been changed, as has the error message - only frames from the third-party server framework and from Python itself have been used as is.)