fix(spans-migration): add validation to not update alerts to transactions or generic_metrics

[nikkikapadia]

had a few cases where orgs were making updates to their migrated transaction alerts via some automated update call which ended up migrating them back to the transactions dataset. We're making sure that updates to alerts like this raise an error.

^{Cursor Bugbot found 2 potential issues for commit 20bb86a}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[cursor]

Stricter validation blocks updates without explicit dataset change

Medium Severity

The refactored is_editing_transaction_dataset uses data_source.get("dataset", current_dataset) which defaults to the current dataset if not specified. The old code used data_source.get("dataset") without a default, returning None if unspecified. This behavioral change means updates to alerts currently on transactions or generic_metrics datasets will now be blocked even when the update doesn't explicitly change the dataset (e.g., only modifying the query parameter). The added tests only cover cases where dataset is explicitly specified in the update request, leaving this edge case untested.

 

[nikkikapadia]

but when dataset is passed as None it will just use the current dataset 🤩

[cursor]

Missing organization check allows silent validation bypass on updates

Medium Severity

The is_editing_transaction_dataset method retrieves organization from context but doesn't validate it before use. If organization is None, features.has(..., None) will likely return False, causing the validation to silently pass and allowing the update to proceed. In contrast, the parallel create-time validation in _validate_transaction_dataset_deprecation (lines 226-228) explicitly raises a ValidationError when organization is missing. This inconsistency means updates could bypass the deprecation check if organization context is somehow absent, while creates would properly fail.