Skip to content

feat(seer): Capture errors when updating onboarding#107683

Merged
billyvg merged 1 commit intomasterfrom
billy/feat-seer-onboarding-capture-error
Feb 5, 2026
Merged

feat(seer): Capture errors when updating onboarding#107683
billyvg merged 1 commit intomasterfrom
billy/feat-seer-onboarding-capture-error

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Feb 5, 2026

Follow up to #107680

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 5, 2026
@billyvg billyvg marked this pull request as ready for review February 5, 2026 17:06
@billyvg billyvg requested a review from a team as a code owner February 5, 2026 17:06
@billyvg billyvg requested a review from ryan953 February 5, 2026 17:06
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

onError: () => {
Sentry.captureException(
new Error('Seer Onboarding: Unable to enable code review')
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error context lost when capturing Sentry exceptions

Low Severity

The onError callback ignores the actual error returned by the mutation and creates a new generic Error instead. The mutation's onError callback receives the real error as its first parameter (as seen in useAutofix.tsx), but these callbacks use () => which discards it. This loses valuable debugging context like HTTP status codes, server error messages, and stack traces. Engineers investigating these errors in Sentry will only see generic messages like "Unable to enable code review" with no information about the actual failure cause.

Additional Locations (2)

Fix in Cursor Fix in Web

onError: () => {
Sentry.captureException(
new Error('Seer Onboarding: Unable to enable code review')
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Sentry capture in second error handler

Low Severity

The PR adds Sentry.captureException to the onError handler in updateEnabledCodeReview (line 71) but misses adding it to the similar onError handler in updateUnselectedRepositories (line 99). Both functions are part of the same onboarding step, call the same updateRepositorySettings mutation, and handle the same type of failure. This creates inconsistent error monitoring where failures to enable code review are captured in Sentry, but failures to disable code review for unselected repositories are not.

Fix in Cursor Fix in Web

@billyvg billyvg force-pushed the billy/feat-seer-onboarding-capture-error branch from 6f5b0eb to 7663dc8 Compare February 5, 2026 17:17
@billyvg billyvg enabled auto-merge (squash) February 5, 2026 17:18
@billyvg billyvg merged commit dab56ea into master Feb 5, 2026
58 checks passed
@billyvg billyvg deleted the billy/feat-seer-onboarding-capture-error branch February 5, 2026 17:25
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
dcramer pushed a commit that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants