feat(dashboards): filter frontend overview by frontend data#107779
Conversation
static/app/views/dashboards/utils/prebuiltConfigs/frontendOverview/frontendOverview.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| 'sentry.javascript.browser', | ||
| 'sentry.javascript.electron', | ||
| 'sentry.javascript.ember', | ||
| 'sentry.javascript.enrio', |
There was a problem hiding this comment.
Invalid SDK name "sentry.javascript.enrio" is a typo
Medium Severity
The SDK name 'sentry.javascript.enrio' is not a valid Sentry JavaScript SDK. This value doesn't exist anywhere else in the codebase and isn't a recognized SDK. The list already includes 'sentry.javascript.ember' on the line above, so this appears to be either a typo or an erroneous entry. Including this invalid SDK name in the filter won't match any actual data.
There was a problem hiding this comment.
Should be valid, we have an internal spreadsheet which lists them all
Following the pattern from the insights page, this PR makes the frontend overview table explicitly filter for frontend data by applying an `sdk.name = [...frontendSdks]` filter. This is a little different because the insights filtered for selected frontend projects, and applied a `projects = [selectedFrontendProjects]` filter, this kept the overall filter string much smaller, but because we're migrating this to dashboards, this is the equivalent way to get it working in dashboards without adding logic into it. Also threw in a minor change to apply `TableWidths = -1` so that the table does not horizontally scroll
Following the pattern from the insights page, this PR makes the frontend overview table explicitly filter for frontend data by applying an `sdk.name = [...frontendSdks]` filter. This is a little different because the insights filtered for selected frontend projects, and applied a `projects = [selectedFrontendProjects]` filter, this kept the overall filter string much smaller, but because we're migrating this to dashboards, this is the equivalent way to get it working in dashboards without adding logic into it. Also threw in a minor change to apply `TableWidths = -1` so that the table does not horizontally scroll


Following the pattern from the insights page, this PR makes the frontend overview table explicitly filter for frontend data by applying an
sdk.name = [...frontendSdks]filter.This is a little different because the insights filtered for selected frontend projects, and applied a
projects = [selectedFrontendProjects]filter, this kept the overall filter string much smaller, but because we're migrating this to dashboards, this is the equivalent way to get it working in dashboards without adding logic into it.Also threw in a minor change to apply
TableWidths = -1so that the table does not horizontally scroll