Skip to content

ref(code-review): Log GH -> seer request time#107834

Merged
kddubey merged 5 commits intomasterfrom
kddubey/log-gh-seer-time
Feb 10, 2026
Merged

ref(code-review): Log GH -> seer request time#107834
kddubey merged 5 commits intomasterfrom
kddubey/log-gh-seer-time

Conversation

@kddubey
Copy link
Contributor

@kddubey kddubey commented Feb 8, 2026

seems like there isn't a way to get this data today, so including it in this existing log. ideally this is a metric, but i'm not sure about cardinality. lmk if i can safely add

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 8, 2026

def log_seer_request(event_payload: Mapping[str, Any], github_event: str) -> None:
repo_data = event_payload.get("data", {}).get("repo", {})
trigger_at_str = event_payload.get("data", {}).get("config", {}).get("trigger_at")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, trigger_at comes from here:

trigger_at = (
pull_request.get("updated_at")
or pull_request.get("created_at")
or datetime.now(timezone.utc).isoformat()
)

The recording of the metric happens at the end of the task execution:

if should_record_latency:
record_latency(status, enqueued_at_str)

The only metric we have on the Sentry side can be seen here (region -> Seer call happens):
https://app.datadoghq.com/dashboard/6x2-jgc-kiz/code-review?fromUser=false&fullscreen_end_ts=1770650225142&fullscreen_paused=false&fullscreen_refresh_mode=sliding&fullscreen_section=overview&fullscreen_start_ts=1770045425142&fullscreen_widget=2461630282246654&refresh_mode=sliding&from_ts=1770645956120&to_ts=1770649556120&live=true

@vaind is already adding latency metrics here: https://github.com/getsentry/seer/pull/4710

If we wanted further granularity we could add these metrics:

  • GitHub -> control
  • control -> region

Once we see @vaind 's metrics live we can determine if we need further granularity.

@armenzg armenzg self-requested a review February 9, 2026 15:41
@kddubey kddubey marked this pull request as ready for review February 9, 2026 20:08
@kddubey kddubey requested a review from a team as a code owner February 9, 2026 20:08
@kddubey kddubey disabled auto-merge February 10, 2026 06:29
@kddubey kddubey enabled auto-merge (squash) February 10, 2026 06:30
@kddubey kddubey merged commit cfead93 into master Feb 10, 2026
72 checks passed
@kddubey kddubey deleted the kddubey/log-gh-seer-time branch February 10, 2026 06:44
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
seems like there isn't a way to get this data today, so including it in
this existing log. ideally this is a metric, but i'm not sure about
cardinality. lmk if i can safely add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants