chore(preprod): Pass retention day values to launchpad via new endpoint#107882
Conversation
github-actions
bot
added
the
Scope: Backend
This stack of pull requests is managed by Graphite. Learn more about stacking. |
NicoHinderling
force-pushed
the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
from
948e7f1 to
11bc0a2
Compare
NicoHinderling
force-pushed
the
02-09-chore_preprod_add_subscription_specific_retention_to_size_build_distro_eap_writes
branch
from
564248f to
2876da5
Compare
| quotas.backend.get_event_retention( | ||
| organization=org, category=DataCategory.SIZE_ANALYSIS | ||
| ) | ||
| or 90 |
There was a problem hiding this comment.
I think if this returns None we want to store forever right? Does objectstore support indefinite retention, if so we should probably forward that some how.
There was a problem hiding this comment.
synced offline. in prod we should always get a value despite what the get_event_retention method's comment says
NicoHinderling
force-pushed
the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
from
11bc0a2 to
614244a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
NicoHinderling
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
NicoHinderling
force-pushed
the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
2 times, most recently
from
34161db to
c29b8c2
Compare
NicoHinderling
force-pushed
the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
2 times, most recently
from
219dec4 to
586e5da
Compare
NicoHinderling
force-pushed
the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
from
586e5da to
e4778b3
Compare
NicoHinderling
deleted the
02-09-chore_preprod_pass_retention_days_value_to_launchpad_for_objectstore_retention
branch
…nt (#107882) Launchpad related PR: getsentry/launchpad#565 --------- Co-authored-by: Claude <noreply@anthropic.com>
2 participants
Launchpad related PR: getsentry/launchpad#565