Conversation
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Feb 9, 2026
| def create_frame_info(frame: Mapping[str, Any], platform: str | None = None) -> FrameInfo: | ||
| """Factory function to create the appropriate FrameInfo instance.""" | ||
| if platform: | ||
| if platform and supported_platform(platform): |
Member
Author
There was a problem hiding this comment.
This change is so that creating a PlatformConfig object doesn't fall for native platforms (any platforms not in PLATFORMS_CONFIG.
scttcper
approved these changes
Feb 9, 2026
shashjar
deleted the
id-1333-enable-set-up-code-mapping-modal-from-issue-details-for-all-platforms-backend-changes
branch
shashjar
added a commit
that referenced
this pull request
Feb 10, 2026
…forms (#107894) Same changes as #107752, just separating backend & frontend changes. Follow-up to #107893. Part of [ID-1333](https://linear.app/getsentry/issue/ID-1333/enable-the-set-up-code-mapping-modal-from-issue-details-for-all). This PR displays the "Set Up Code Mapping" button from in-app stack frames on the issue details page for all platforms. After changes: <img width="355" height="342" alt="image" src="https://github.com/user-attachments/assets/919d1572-08de-46d5-8386-cd3669d65dd5" /> <img width="343" height="337" alt="image" src="https://github.com/user-attachments/assets/7dc8d286-af04-40ff-8d5d-a40f5f05aa06" />
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…back to default frame info (#107893) Same changes as #107752, just separating backend & frontend changes. Precursor to #107894. Part of [ID-1333](https://linear.app/getsentry/issue/ID-1333/enable-the-set-up-code-mapping-modal-from-issue-details-for-all). The "Set Up Code Mapping" modal is different from the code mapping config in the integration settings. The former takes the source code URL for the file and attempts to derive what the source/stack root should be; the latter just asks for that input directly. To account for this, I modified `src/sentry/issues/auto_source_code_config/frame_info.py` to not fail for any "unsupported" platforms. The only effect of this will be that there's no auto-suggested URL in the modal for native platforms, but creating a code mapping will still work from there. No regression/change in behavior for platforms that are already included in `PLATFORMS_CONFIG`.
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…forms (#107894) Same changes as #107752, just separating backend & frontend changes. Follow-up to #107893. Part of [ID-1333](https://linear.app/getsentry/issue/ID-1333/enable-the-set-up-code-mapping-modal-from-issue-details-for-all). This PR displays the "Set Up Code Mapping" button from in-app stack frames on the issue details page for all platforms. After changes: <img width="355" height="342" alt="image" src="https://github.com/user-attachments/assets/919d1572-08de-46d5-8386-cd3669d65dd5" /> <img width="343" height="337" alt="image" src="https://github.com/user-attachments/assets/7dc8d286-af04-40ff-8d5d-a40f5f05aa06" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes as #107752, just separating backend & frontend changes.
Precursor to #107894.
Part of ID-1333.
The "Set Up Code Mapping" modal is different from the code mapping config in the integration settings. The former takes the source code URL for the file and attempts to derive what the source/stack root should be; the latter just asks for that input directly.
To account for this, I modified
src/sentry/issues/auto_source_code_config/frame_info.pyto not fail for any "unsupported" platforms. The only effect of this will be that there's no auto-suggested URL in the modal for native platforms, but creating a code mapping will still work from there. No regression/change in behavior for platforms that are already included inPLATFORMS_CONFIG.