Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
61
to
67
| query: [queryParam, value].filter(v => v).join(':'), | ||
| per_page: 10, | ||
| }; | ||
| const results = await api.requestPromise(path, { | ||
| const results = await api.requestPromise(searchPath, { | ||
| method: 'GET', | ||
| host: searchHost, | ||
| data: queryParams, |
Contributor
There was a problem hiding this comment.
Bug: Changing the region while a debounced search is pending causes the API request to be sent to the old, incorrect endpoint.
Severity: MEDIUM
Suggested Fix
Cancel the pending debounced function when the path prop changes. This can be achieved by calling the .cancel() method on the debounced function within a useEffect hook that has path in its dependency array. Alternatively, recreate the debounced function using useMemo with path as a dependency instead of useRef.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/gsAdmin/components/debounceSearch.tsx#L61-L67
Potential issue: A race condition exists in the `DebounceSearch` component. The
`debouncedSearch` function is created once via `useRef` and does not reset when its
`path` prop changes. If a user types in the search input and then changes the region
within the 300ms debounce delay, the search will execute with the original `path`. This
sends the API request to the incorrect regional endpoint, potentially returning results
from the wrong region or a 404 error. This behavior is introduced by this pull request,
which makes the search path dynamic.
Did we get this right? 👍 / 👎 to inform future reviews.
markstory
approved these changes
Feb 10, 2026
markstory
deleted the
shellmayr/fix/admin-fix-customers-cell-api-endpoint
branch
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…ure (#107927) - With the new cells architecture, API URLs have changed - some of the APIs that _admin calls therefore 404, breaking some of the admin flows - This PR fixes the problem by routing debounced searches to the respective cells if applicable Before: <img width="299" height="231" alt="image" src="https://github.com/user-attachments/assets/c142ff5b-47d8-497c-8784-8dcb0eab477f" /> Afterwards: shows a dropdown with orgs - omitted the image for obvious reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Afterwards: shows a dropdown with orgs - omitted the image for obvious reasons