Skip to content

feat(seer): Update the copy when selecting many/all Projects and Repos inside Seer settings#107999

Merged
ryan953 merged 1 commit intomasterfrom
ryan953/seer-list-selectall-copy
Feb 11, 2026
Merged

feat(seer): Update the copy when selecting many/all Projects and Repos inside Seer settings#107999
ryan953 merged 1 commit intomasterfrom
ryan953/seer-list-selectall-copy

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Feb 11, 2026

SCR-20260210-odcm

Fixes CW-756

@ryan953 ryan953 requested a review from a team as a code owner February 11, 2026 00:01
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 11, 2026
@linear
Copy link

linear bot commented Feb 11, 2026

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

{queryString
? tct('Selected all projects matching: [queryString].', {
? tct('Selected all [count] projects matching: [queryString].', {
count: countSelected,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing pluralization for singular count in query path

Low Severity

When isAllSelected === true and a query string is present, the new tct call always renders the plural form (e.g., "Selected all 1 projects matching: …"). The non-query path correctly uses tn() to distinguish singular ("Selected 1 project.") from plural, but the query-string path hardcodes "projects"/"repositories" without pluralization. This can happen when a search returns exactly one result and it is selected. The same issue exists in both the project and repo table headers.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member Author

@ryan953 ryan953 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false-ish! these two cases (2 cases per file) will only render when there are at least 2 items to be picked. you need to have one picked already, so the suggestion for 'all' must be for 2+ items. plural enough for us with our weak translations.

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does select all here account for pagination? e.g. if we have multiple pages will hits be the # of results returned on first page or all pages?

@ryan953
Copy link
Member Author

ryan953 commented Feb 11, 2026

Does select all here account for pagination? e.g. if we have multiple pages will hits be the # of results returned on first page or all pages?

There's no pagination right now. the page is slow for getsentry/* and some bigger customers too. But the messaging should work provided that the X-Hits response heading is returned with paginated data

@ryan953 ryan953 merged commit 621a1ea into master Feb 11, 2026
61 checks passed
@ryan953 ryan953 deleted the ryan953/seer-list-selectall-copy branch February 11, 2026 17:11
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
…s inside Seer settings (#107999)

<img width="1147" height="753" alt="SCR-20260210-odcm"
src="https://github.com/user-attachments/assets/0ec69a1f-b05f-4da3-9ff2-1e320d3ea1cc"
/>

Fixes CW-756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants