Skip to content

ref(pagefilters) cleanup projectFilters#108072

Merged
JonasBa merged 17 commits intomasterfrom
jb/projectfilters/search
Feb 13, 2026
Merged

ref(pagefilters) cleanup projectFilters#108072
JonasBa merged 17 commits intomasterfrom
jb/projectfilters/search

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Feb 11, 2026

Refactors hybridFilters to cleanup styling and confusing UX.

Changes:

  • Row icon button have consistent shape and hover state (bookmark was previously round with only project and settings having a blue link state)
  • BookmarkStar is no longer a round button (design system doesn't support it and it should have never been restyled)
  • Footer tip has been removed - we need the UX to be predictable without having to explain it
  • Removed show more message at the end of the list, the users focus is already on the search itself due to autofocus, we don't need to explain this twice.
  • footer + Project was renamed to + Create Project

I will use this PR as the base for a set of stacked changes that I would like to release at the same time so that there is minimal impact on user experience.

Fix DE-754, Fix DE-883

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 11, 2026
@linear
Copy link

linear bot commented Feb 11, 2026

@JonasBa JonasBa marked this pull request as ready for review February 12, 2026 19:18
@JonasBa JonasBa requested a review from a team as a code owner February 12, 2026 19:18
Moves checkbox position to the beginning of the row and unwinds the mess
of checkwraps.

<img width="666" height="624" alt="CleanShot 2026-02-11 at 16 28 05@2x"
src="https://github.com/user-attachments/assets/4fe46a08-9619-49b7-9377-fb58088495cb"
/>

Fix DE-752
@JonasBa JonasBa requested review from a team as code owners February 12, 2026 21:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 12, 2026
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this contains changes that we’ve already approved in a different PR, making it hard to review

@JonasBa JonasBa changed the title ref(pagefilters) improve projectFilters user experience ref(pagefilters) cleanup projectFilters Feb 13, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@JonasBa JonasBa enabled auto-merge (squash) February 13, 2026 16:51
@JonasBa JonasBa disabled auto-merge February 13, 2026 17:15
@JonasBa JonasBa enabled auto-merge (squash) February 13, 2026 17:22
@JonasBa JonasBa merged commit 6f84c33 into master Feb 13, 2026
98 checks passed
@JonasBa JonasBa deleted the jb/projectfilters/search branch February 13, 2026 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants