fix(perf-cli): Pass detector-specific settings in sentry performance commands #108074
Merged
roggenkemper merged 1 commit intomasterfrom Feb 11, 2026
Merged
Conversation
…` commands The `PerformanceDetector` constructor was refactored in #107387 to accept only the detector's own settings dict instead of the full settings dict. The `sentry performance detect` and `sentry performance timeit` CLI commands were not updated, causing them to pass the full settings dict and break. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes in #107387 didn't touch the CLI commands, this pr makes the necessary changes so the CLI commands work