Conversation
…ng when necessary
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Feb 12, 2026
| return results | ||
|
|
||
| @classmethod | ||
| def _build_category_filter(cls, category: OccurrenceCategory | None) -> TraceItemFilter | None: |
Member
Author
There was a problem hiding this comment.
OccurrenceCategory.ERROR --> filter is type != "generic"
OccurrenceCategory.GENERIC --> filter is type == "generic"
This is to be on the safer side since (I believe) "generic" is the only possible event type value for issue platform events, while there are several possible type values for error events. However - we are forwarding only events with type = "error" or type = "generic" to EAP (eventstream code), so either way should work as expected.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
shashjar
deleted the
add-eap-type-attribute-on-occurrences-for-filtering
branch
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
…g error/issue platform events (#108099) Adds a `type` attribute to the EAP occurrence definitions, making it queryable via the search resolver. The `OccurrenceCategory` enum provides an API in the `Occurrences` RPC class for consumers to filter their queries down to either error events (`error`) or issue platform events (`generic`). The default behavior will continue to be querying all occurrence trace items as a whole. Applies `OccurrenceCategory.ERROR` as the filter to all existing EAP callsites where we want to query errors only.
DominikB2014
pushed a commit
that referenced
this pull request
Feb 13, 2026
…g error/issue platform events (#108099) Adds a `type` attribute to the EAP occurrence definitions, making it queryable via the search resolver. The `OccurrenceCategory` enum provides an API in the `Occurrences` RPC class for consumers to filter their queries down to either error events (`error`) or issue platform events (`generic`). The default behavior will continue to be querying all occurrence trace items as a whole. Applies `OccurrenceCategory.ERROR` as the filter to all existing EAP callsites where we want to query errors only.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
typeattribute to the EAP occurrence definitions, making it queryable via the search resolver. TheOccurrenceCategoryenum provides an API in theOccurrencesRPC class for consumers to filter their queries down to either error events (error) or issue platform events (generic). The default behavior will continue to be querying all occurrence trace items as a whole.Applies
OccurrenceCategory.ERRORas the filter to all existing EAP callsites where we want to query errors only.