feat(uptime-detector-ongoing-issues): Ignoring date selection for uptime ongoing issues#108144
Merged
feat(uptime-detector-ongoing-issues): Ignoring date selection for uptime ongoing issues#108144
Conversation
…ime ongoing issues
github-actions
bot
added
the
Scope: Frontend
jaydgoss
requested changes
Feb 12, 2026
| <DetectorDetailsOngoingIssues | ||
| detector={detector} | ||
| issueLinkExtraQuery={{includeUptime: '1'}} | ||
| dateTimeSelection={null} |
Member
There was a problem hiding this comment.
No test coverage for the null case. Would be nice to assert the issues request omits date params when dateTimeSelection={null}.
Contributor
Author
There was a problem hiding this comment.
Done, added some tests
| const query = `is:unresolved detector:${detector.id}`; | ||
| const {selection} = usePageFilters(); | ||
| const {start, end, period} = dateTimeSelection ?? {}; | ||
| const queryParams = { |
Member
There was a problem hiding this comment.
nit: When dateTimeSelection is null, the "View All" link has no date params so the Issues page applies its own default (14d) — which differs from the backend's 90d default used for the inline list. Users might see fewer results after clicking through. (maybe not a problem)
Contributor
Author
There was a problem hiding this comment.
Done, used 90d as a default from the FE
jaydgoss
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
nullleads to the consumers being a bit deliberate about their choice of time range.