Skip to content

fix(frontend): include react config for our pipeline asset response#108157

Merged
trevor-e merged 2 commits intomasterfrom
telkins/fix-react-pipeline
Feb 12, 2026
Merged

fix(frontend): include react config for our pipeline asset response#108157
trevor-e merged 2 commits intomasterfrom
telkins/fix-react-pipeline

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Feb 12, 2026

When trying to set up a Github app integration locally on my dev box, the popup window infinitely loads with our asset loading animation. Inspecting the browser dev tools shows a bunch of ChunkLoadError when loading asset chunks, I think because it's trying to load from /_assets/chunks/... instead of /_static/dist/sentry/chunks/.... My theory is it's only happening on this page (that I can tell) because most other pages use ReactPageView which correctly passes the react_config.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 12, 2026
@trevor-e trevor-e changed the title fix(frontend): include react config for our pipeline asset fix(frontend): include react config for our pipeline asset response Feb 12, 2026
@trevor-e trevor-e marked this pull request as ready for review February 12, 2026 20:49
@trevor-e trevor-e requested a review from a team as a code owner February 12, 2026 20:49
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had claude check how the config data would propagate from initializePipelineView and it doesn't seem like there would be any unwanted side-effects. bonus, our SDK will work on these views

@billyvg
Copy link
Member

billyvg commented Feb 12, 2026

these marks don't do anything anymore :(

@trevor-e
Copy link
Member Author

I was trying to spot some differences with prod and really only noticed that window.__initialData is "" locally (before this fix) and undefined in prod.

After this fix it seems to correctly initialize to the config object needed for initializePipelineView

@trevor-e trevor-e merged commit e3e1b82 into master Feb 12, 2026
76 checks passed
@trevor-e trevor-e deleted the telkins/fix-react-pipeline branch February 12, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants