Skip to content

feat(scraps): info pattern components#108205

Merged
TkDodo merged 12 commits intomasterfrom
tkdodo/feat/de-925-create-info-components
Feb 17, 2026
Merged

feat(scraps): info pattern components#108205
TkDodo merged 12 commits intomasterfrom
tkdodo/feat/de-925-create-info-components

Conversation

@TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Feb 13, 2026

This PR adds two new patterns to scraps:

InfoTip

An info icon that contains a tooltip that’s keyboard accessible:

Screenshot 2026-02-13 at 10 38 22

The focus state is done with our default focusRing:

Screenshot 2026-02-13 at 10 38 31

InfoText

An underlined text with help cursor that shows a tooltip upon hover and focus. Also keyboard accessible with a focusRing, otherwise just a normal Text component:

Screenshot 2026-02-13 at 10 40 33

@linear
Copy link

linear bot commented Feb 13, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 13, 2026
@TkDodo TkDodo marked this pull request as ready for review February 13, 2026 14:17
@TkDodo TkDodo requested review from a team as code owners February 13, 2026 14:17
@TkDodo TkDodo requested a review from JonasBa February 16, 2026 11:05
Co-authored-by: Dominik Dorfmeister <TkDodo@users.noreply.github.com>
@TkDodo TkDodo enabled auto-merge (squash) February 17, 2026 08:40
@TkDodo TkDodo merged commit 7e93fa1 into master Feb 17, 2026
61 checks passed
@TkDodo TkDodo deleted the tkdodo/feat/de-925-create-info-components branch February 17, 2026 08:46
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

position?: TooltipProps['position'];
}

export function InfoTip({title, position, ...props}: InfoTooltipProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InfoTip default size doesn't match documented default

Medium Severity

The InfoTip documentation states sm is the default size, but the component doesn't set a default for size in its destructuring. The prop flows through ...props into IconQuestionSvgIcon, which defaults to md (16px). Users relying on the documented sm default (14px) will get a visually larger icon than expected.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants