Conversation
github-actions
bot
added
the
Scope: Frontend
TkDodo
commented
Feb 13, 2026
Comment on lines
+136
to
+138
| // Boolean fields (like switches) save on change, others save on blur | ||
| const fieldSchema = schema.shape[name]; | ||
| const saveOnChange = fieldSchema ? isBooleanField(fieldSchema) : false; |
Collaborator
Author
There was a problem hiding this comment.
the problem is that some fields should auto-save immediately, onChange, not onBlur. Since we have a schema, we can auto detect this for boolean fields
JonasBa
reviewed
Feb 13, 2026
| checkbox.focus(); | ||
| expect(checkbox).not.toBeChecked(); | ||
|
|
||
| await userEvent.keyboard(' '); |
Member
There was a problem hiding this comment.
Thank you for adding tests for this 🙏🏼
JonasBa
approved these changes
Feb 13, 2026
Member
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
The tests, JSX and the logic behind the form system is just so enjoyable to read, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
<field.Switch>, which renders the core switch component as a form field