fix(form): stabilize the SelectIndicatorsContainer component#108214
Merged
fix(form): stabilize the SelectIndicatorsContainer component#108214
Conversation
the inline component was making react re-mount the component, which (among other things) made the save animation show up again on each re-render. to create a stable component, we can't rely on indicator passed in as a prop from baseField, but we can just invoke the hook directly. To streamline, all fields do it like this now.
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the inline component was making react re-mount the component, which (among other things) made the save animation show up again on each re-render.
to create a stable component, we can't rely on indicator passed in as a prop from baseField, but we can just invoke the hook directly. To streamline, all fields do it like this now.