Skip to content

fix(dashboards): Include yAxis equations in top events table query#108228

Merged
DominikB2014 merged 2 commits intomasterfrom
dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview
Feb 13, 2026
Merged

fix(dashboards): Include yAxis equations in top events table query#108228
DominikB2014 merged 2 commits intomasterfrom
dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Feb 13, 2026

Summary

  • When sorting top events by an equation from yAxis (e.g. equation|count()), the equation was not included in the table query's resolved columns, causing an orderby must also be in the selected columns or groupby validation error.
  • categorize_columns(y_axes) correctly separates equation axes from non-equation axes, but the extracted equations were being discarded. Now they are merged with any separately passed equations before being forwarded to the table query.

Fixes BROWSE-330

@DominikB2014 DominikB2014 requested review from a team as code owners February 13, 2026 16:35
@linear
Copy link

linear bot commented Feb 13, 2026

@DominikB2014 DominikB2014 requested review from a team as code owners February 13, 2026 16:35
@DominikB2014 DominikB2014 marked this pull request as draft February 13, 2026 16:35
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Feb 13, 2026
@DominikB2014 DominikB2014 force-pushed the dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview branch from 7b94e08 to 84fdab7 Compare February 13, 2026 16:37
@DominikB2014 DominikB2014 removed request for a team February 13, 2026 16:37
@DominikB2014 DominikB2014 removed request for a team February 13, 2026 16:37
@getsentry getsentry deleted a comment from github-actions bot Feb 13, 2026
@DominikB2014 DominikB2014 force-pushed the dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview branch from 84fdab7 to a7fa78d Compare February 13, 2026 16:39
@DominikB2014 DominikB2014 marked this pull request as ready for review February 13, 2026 16:39
Equations from yAxis were being discarded when building the top events
table query, causing orderby validation to fail when sorting by an
equation like `equation|tpm()`.
@DominikB2014 DominikB2014 force-pushed the dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview branch from a7fa78d to 871b4bb Compare February 13, 2026 16:43
@DominikB2014 DominikB2014 enabled auto-merge (squash) February 13, 2026 16:51
@DominikB2014 DominikB2014 merged commit 2601b32 into master Feb 13, 2026
79 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-330-open-in-explore-breaks-with-frontend-overview branch February 13, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants