Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| category: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| subcategory: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| verification_reason: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| group_for_fingerprint: str | None = Field(None, max_length=MAX_LLM_FIELD_LENGTH) |
| fingerprint = [f"llm-detected-{title}-{transaction_name}"] | ||
| fingerprint = ( | ||
| [f"llm-detected-{group_for_fingerprint.lower().replace(' ', '-')}-{transaction_name}"] | ||
| if group_for_fingerprint is not None |
There was a problem hiding this comment.
is there a valid case for this being none?
There was a problem hiding this comment.
I thought some issue types didn't have the verification stage yet. Will any issue that gets to this function have gone through that stage?
There was a problem hiding this comment.
ah I see. Yes all of them go through verification - some of them go through additional custom verification that gets added to the base verification
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| category: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| subcategory: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| verification_reason: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) | ||
| group_for_fingerprint: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH) |
There was a problem hiding this comment.
Required field breaks older detection payloads
Medium Severity
DetectedIssue now requires group_for_fingerprint, so create_issue_occurrence rejects payloads that were valid before this change. Any in-flight or lagging Seer responses without this key will raise ValidationError and skip issue creation.
shayna-ch
deleted the
shayna-ch/llm-detected-issues-group-for-fingerprint
branch
2 participants
use group_for_fingerprint